Skip to content

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Feb 28, 2025

Changes:

  • Reduce --max-model-len to match new model
  • Update compared embedding size (new model has smaller embedding dim)
  • Update compared token counts (new model uses a different tokenizer)

Should fix https://buildkite.com/vllm/ci/builds/14338#01954bc1-23f7-4376-9330-118d17be22fe

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 28, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 28, 2025 15:51
@hmellor hmellor changed the title Reduce --max-model-len to match new model Fix entrypoint tests for embedding models Feb 28, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@vllm-bot vllm-bot merged commit 4be4b26 into vllm-project:main Feb 28, 2025
13 of 15 checks passed
@hmellor hmellor deleted the fix-entrypoint-embeddings branch February 28, 2025 16:57
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants