Skip to content

[Bugfix] Fix torch_xla in V0 which can't handle None seed introduced … #14844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2025
Merged

[Bugfix] Fix torch_xla in V0 which can't handle None seed introduced … #14844

merged 1 commit into from
Mar 15, 2025

Conversation

@yarongmu-google
Copy link
Contributor

@yarongmu-google yarongmu-google commented Mar 14, 2025 •
edited by github-actions bot
Loading

…in #14274

FIX #14274

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@khluu khluu enabled auto-merge (squash) March 14, 2025 22:33
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 14, 2025
@khluu khluu merged commit dd344e0 into vllm-project:main Mar 15, 2025
42 of 47 checks passed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@yarongmu-google @lulmer
[Bugfix] Fix torch_xla in V0 which can't handle None seed introduced … (
bbfc31b 
vllm-project#14844)

Signed-off-by: Yarong Mu <ymu@google.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@yarongmu-google @shreyankg
[Bugfix] Fix torch_xla in V0 which can't handle None seed introduced … (
e064a8a 
vllm-project#14844)

Signed-off-by: Yarong Mu <ymu@google.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@yarongmu-google
[Bugfix] Fix torch_xla in V0 which can't handle None seed introduced … (
808b2d0 
vllm-project#14844)

Signed-off-by: Yarong Mu <ymu@google.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khluu khluu khluu approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yarongmu-google @khluu