Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Worker] Fix input_metadata.selected_token_indices in worker #1546

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

ymwangg
Copy link
Contributor

@ymwangg ymwangg commented Nov 2, 2023

This PR fixes a bug when sequences have different prompt lens.

Copy link
Collaborator

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@esmeetu esmeetu mentioned this pull request Nov 7, 2023
3 tasks
@irasin
Copy link
Contributor

irasin commented Nov 8, 2023

Hi @Yard1, just wonder when this PR can be merged into the main branch

@Yard1
Copy link
Collaborator

Yard1 commented Nov 8, 2023

@irasin I do not have the permissions to do that. cc @WoosukKwon @zhuohan123

Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@zhuohan123 zhuohan123 merged commit 8efe23f into vllm-project:main Nov 8, 2023
2 checks passed
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants