Skip to content

Conversation

@NickLucche
Copy link
Collaborator

@NickLucche NickLucche commented Apr 11, 2025

Implements feature requested in #16354.

Test with:

# server
vllm serve openai/whisper-large-v3-turbo

# client
python3 benchmarks/benchmark_serving.py \       
    --backend openai-audio \
    --dataset-name hf \
    --dataset-path edinburghcstr/ami --hf-subset ihm \
    --model openai/whisper-large-v3-turbo \
    --num-prompts 1000 \
    --endpoint /v1/audio/transcriptions \
    --save-result \
    2>&1 | tee benchmark_whisper.txt

It's still a draft because I want to sweep through the datasets first, but reviews are welcome!
cc @DarkLight1337

FIX #16354

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@NickLucche NickLucche marked this pull request as ready for review April 14, 2025 15:18
@NickLucche
Copy link
Collaborator Author

PS: these datasets need to be granted access manually on hf. Posting here in case we decide to run performance checks on them:
https://huggingface.co/datasets/speechcolab/gigaspeech
https://huggingface.co/datasets/kensho/spgispeech

@DarkLight1337
Copy link
Member

Can you merge from main to try to fix the CI errors?

Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: NickLucche <nlucches@redhat.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 18, 2025 09:49
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 18, 2025
@vllm-bot vllm-bot merged commit 9d4ca19 into vllm-project:main Apr 19, 2025
26 of 30 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
Signed-off-by: NickLucche <nlucches@redhat.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
Signed-off-by: NickLucche <nlucches@redhat.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Benchmarks for audio models

3 participants