Skip to content

[doc] update wrong hf model links #17184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

[doc] update wrong hf model links #17184

merged 1 commit into from
Apr 25, 2025

Conversation

@reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Apr 25, 2025 •
edited by github-actions bot
Loading

It cannot show the related models from the old links, so update it.

@reidliu41
[doc] update wrong hf model links
cb8a746 
Signed-off-by: reidliu41 <reid201711@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 25, 2025
@DarkLight1337 DarkLight1337 requested a review from hmellor April 25, 2025 15:33
hmellor
hmellor approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Trending is the default sort so removing that from the links is good.
  • Of the changed links the only one that was broken before was bitblas because there is no bitblas tag. The other links were valid.
  • Even though the other links were valid, I think the search page will currently be more appealing to users because they will have the task selectors on the left.

@hmellor hmellor enabled auto-merge (squash) April 25, 2025 15:58
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 25, 2025
@hmellor hmellor merged commit df5c879 into vllm-project:main Apr 25, 2025
42 checks passed
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@reidliu41 @dbyoung18
[doc] update wrong hf model links (vllm-project#17184)
a818d05 
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@reidliu41 @lk-chen
[doc] update wrong hf model links (vllm-project#17184)
50c2432 
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@reidliu41 @adobrzyn
[doc] update wrong hf model links (vllm-project#17184)
2bccc3c 
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@reidliu41
[doc] update wrong hf model links (vllm-project#17184)
07ba5df 
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmellor hmellor hmellor approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reidliu41 @hmellor