Skip to content

[Misc] support model prefix & add deepseek vl2 tiny fused moe config #17763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2025
Merged

[Misc] support model prefix & add deepseek vl2 tiny fused moe config #17763

merged 2 commits into from
May 8, 2025

Conversation

@xsank
Copy link
Contributor

@xsank xsank commented May 7, 2025 •
edited by github-actions bot
Loading

support model prefix & add deepseek vl tiny fused moe config
8a90432 
Signed-off-by: 唯勤 <xsank.mz@alibaba-inc.com>
@github-actions
Copy link

github-actions bot commented May 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

support model prefix & add deepseek vl tiny fused moe config
0d260cc 
Signed-off-by: 唯勤 <xsank.mz@alibaba-inc.com>
ywang96
ywang96 approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the contribution!

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label May 7, 2025
@ywang96 ywang96 enabled auto-merge (squash) May 7, 2025 08:57
@DarkLight1337
Copy link
Member

MoE test failed, PTAL

@xsank
Copy link
Contributor Author

xsank commented May 8, 2025

MoE test failed, PTAL

strange... let me see see...

@xsank
Copy link
Contributor Author

xsank commented May 8, 2025

@DarkLight1337 @ywang96 it seems my changes have nothing to do with the test error.

@DarkLight1337
Copy link
Member

Let's wait for next nightly to see whether this test is failing on main as well.

@DarkLight1337
Copy link
Member

Ok it looks like the test is flaky on main, let me retry it.

@ywang96 ywang96 merged commit 0a9bbaa into vllm-project:main May 8, 2025
73 checks passed
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
@xsank @princepride
[Misc] support model prefix & add deepseek vl2 tiny fused moe config (v…
40e407b 
…llm-project#17763)

Signed-off-by: 唯勤 <xsank.mz@alibaba-inc.com>
Co-authored-by: 唯勤 <xsank.mz@alibaba-inc.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@xsank
[Misc] support model prefix & add deepseek vl2 tiny fused moe config (v…
9eb5859 
…llm-project#17763)

Signed-off-by: 唯勤 <xsank.mz@alibaba-inc.com>
Co-authored-by: 唯勤 <xsank.mz@alibaba-inc.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@xsank @mawong-amd
[Misc] support model prefix & add deepseek vl2 tiny fused moe config (v…
50597eb 
…llm-project#17763)

Signed-off-by: 唯勤 <xsank.mz@alibaba-inc.com>
Co-authored-by: 唯勤 <xsank.mz@alibaba-inc.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@xsank
[Misc] support model prefix & add deepseek vl2 tiny fused moe config (v…
1ec24f1 
…llm-project#17763)

Signed-off-by: 唯勤 <xsank.mz@alibaba-inc.com>
Co-authored-by: 唯勤 <xsank.mz@alibaba-inc.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywang96 ywang96 ywang96 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xsank @DarkLight1337 @ywang96