Skip to content

Conversation

@mickaelseznec
Copy link
Contributor

@mickaelseznec mickaelseznec commented Jul 18, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Previously, when setting TORCH_CUDA_ARCH_LIST="9.0" for example, vllm would complain because some symbols were missing.

sm100_cutlass_mla_get_workspace_size is indeed referenced in csrc/torch_bindings.cpp

Add stubs to fix this situation.

Test Plan

Test Result

(Optional) Documentation Update

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Mickael Seznec <mickael@mistral.ai>
@mickaelseznec mickaelseznec force-pushed the mseznec/fix-no-sm100-compilation branch from 77ef73b to 954b5ed Compare July 18, 2025 16:30
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a compilation failure when vLLM is built without support for sm100 architectures by adding stub implementations for missing symbols. To fully resolve the issue, I've added a critical comment to include the missing stub for sm100_cutlass_mla_decode.

Signed-off-by: Mickael Seznec <mickael@mistral.ai>
Signed-off-by: Mickael Seznec <mickael@mistral.ai>
@mickaelseznec
Copy link
Contributor Author

@LucasWilkinson for viz since you reviewed #16032

(I don't know why the reviewers haven't been set with my PR)

Signed-off-by: Mickael Seznec <mickael@mistral.ai>
@mickaelseznec mickaelseznec force-pushed the mseznec/fix-no-sm100-compilation branch from b29cf72 to f2fab0b Compare July 22, 2025 16:32
Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! is this still needed after: #21020 ?

@mickaelseznec
Copy link
Contributor Author

np! Yes I confirm that you fixed it there already :) Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants