🐞 [Bug] Shaman Clearcast Consumed by Spell that Procced Clearcast

[soundbrands]

-->

🐞 Bug report - Spell

The Clearcasting effect from the Shaman talent Elemental Focus has a chance to proc whenever a damaging spell finishes casting.

However, if the spell that procs Clearcasting has a travel time (e.g. Lightning Bolt), and if another cast is begun while that spell is still traveling, the Clearcasting proc is consumed when the spell that initially procced the clearcast lands, rather than by the next spell that is cast.

Expected behavior

Clearcasting procs when a spell finishes casting. It should make the next spell cast cost no mana. It should not be consumed by the spell that procced it, as this spell has already consumed mana and this provides no benefit.

This can be inferred from the description of the talent, which says " Gives you a 10% chance to enter a Clearcasting state after casting any Fire, Frost or Nature damage spell. The Clearcasting state reduces the mana cost of your next damage spell by 100%."

Steps to reproduce

1. Learn the Shaman talent "Elemental Focus"
2. Open the combat log
3. Continously cast Lightning Bolts at a creature or target dummy that is far enough away that another cast can be begun while the bolt is traveling
4. After a Clearcast proc, notice that when the spell that procced it lands, the combat log says "Clearcast fades from you", and that the next spell cast did not have its mana cost reduced.

Version & Environment

Client Version: 1.12.1.5875

Commit Hash:

[soundbrands]

1: Lightning Bolt is casting
2: Lightning Bolt finishes casting, procs Clearcast
3: While another spell is being cast, the Lightning Bolt that procced Clearcast Lands, consuming Clearcast
4: The other spell finishes casting and its mana cost is not reduced

[FlagFlayer]

This can be inferred from the description of the talent, which says " Gives you a 10% chance to enter a Clearcasting state after casting any Fire, Frost or Nature damage spell. The Clearcasting state reduces the mana cost of your next damage spell by 100%."

You should beware trusting the game, as WoW text can often be inaccurate. However, I did check on the PTR though and your description of the expected behaviour is correct for that. Just need to make sure it's not some bug that existed in vanilla and was patched out by Blizzard for Classic.

[soundbrands]

Skill descriptions can definitely be misleading (and things do change under the hood from patch to patch), that's absolutely right. I can't see any mention of Elemental Focus changing in any patch notes, however (though I know they don't always cover everything).

My suspicion is that #1363 was a slightly faulty implementation that lacked a check for the spell that procced the effect's own landing.. Hopefully someone knows!

Edit: Something I am not certain of, because the classic wow ptr obviously has a functioning implementation that wouldn't reveal this bug, is whether Clearcasting should be consumed when the next spell lands, rather than on the next successful spellcast. The implementation we have on vmangos, based on how lightning bolt consumes its own proc, suggests to me that Clearcast is checking against the next spell landing rather than the next spell cast. This could be the issue.