Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax error with complex configuration #12

Closed
GeorgFleig opened this issue Jun 1, 2016 · 6 comments
Closed

syntax error with complex configuration #12

GeorgFleig opened this issue Jun 1, 2016 · 6 comments
Assignees
Labels
regression Something broken that used to work

Comments

@GeorgFleig
Copy link

GeorgFleig commented Jun 1, 2016

Hi,
I have some trouble setting up thinkfan using complex mode. I am running the latest version of thinkfan on a T500 which provides 16 sensors. However when using the complex configuration file provided by this repo I get the following error message:

root@tp:/etc# /usr/local/sbin/thinkfan 

ERROR: /etc/thinkfan.conf:65: Syntax error:
{ level 0   # the fan level
^

As far as I understand I don't need to adjust the provided config file as the number of sensors is the same (16). Did I miss something?

Thanks for this great tool and the support!

@vmatare vmatare self-assigned this Jun 2, 2016
@vmatare vmatare added the bug Behavior not as intended label Jun 2, 2016
@vmatare
Copy link
Owner

vmatare commented Jun 2, 2016

Thanks for the report, this is indeed a bug. Some of the features used in that example config are still missing from the config parser.

@vmatare vmatare added this to the 1.0 stable release milestone Jun 7, 2016
@ghost
Copy link

ghost commented Jun 8, 2016

Just to say I see a slightly different message using the complex config.

ERROR: Invalid config: Inconsistent limit length

Thanks

@vmatare
Copy link
Owner

vmatare commented Jun 8, 2016

Yup, there are actually multiple issues here, two of which have been fixed by the two last commits. The third requires some larger changes in the parser which will take some time. As a workaround, you can remove the dots from the fan levels and replace them with sensible temperature limits, or you can use simple mode with correction values.

@ghost
Copy link

ghost commented Jun 8, 2016

Thanks, that works. :)

@vmatare vmatare added regression Something broken that used to work and removed bug Behavior not as intended labels Jun 10, 2016
@vmatare
Copy link
Owner

vmatare commented Jul 23, 2016

This is supposed to be fixed by commit 5346b6e, so anyone affected by this might want to retry with the current master.

@GeorgFleig
Copy link
Author

Thanks, seems to be working for me with the current version.

@vmatare vmatare closed this as completed Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Something broken that used to work
Projects
None yet
Development

No branches or pull requests

2 participants