Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Remove the status check of a volume on the plugin side #1230

Open
pshahzeb opened this issue May 9, 2017 · 1 comment
Open

Remove the status check of a volume on the plugin side #1230

pshahzeb opened this issue May 9, 2017 · 1 comment
Assignees
Milestone

Comments

@pshahzeb
Copy link
Contributor

pshahzeb commented May 9, 2017

The status of a volume in its meta data (result of GetVolume) is used to check if it is detached or not.
Generally we don't make decision based on data in KV file and definitely not inside guest. Disk may be attached to some other VM. If neither refCnt nor mount map suggest disk is attached to this VM then we must issue attach to ESX. If it is already attached, it is a no-op from ESX perspective anyway.

@shuklanirdesh82 shuklanirdesh82 added this to the 0.17 milestone Jun 1, 2017
@tusharnt tusharnt removed this from the 0.17 milestone Jul 18, 2017
@govint govint added this to the Sprint - Rafiki milestone Sep 13, 2017
@govint
Copy link
Contributor

govint commented Sep 13, 2017

@pshahzeb can you quickly confirm that this issue needs fixing, given the current code and the recent changes in the refcnt and mount logic. Setting to rafiki as it should be either fixed or dropped.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants