Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typography): use surrounding font size for inline code #319

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

valentin-mladenov
Copy link
Contributor

@valentin-mladenov valentin-mladenov commented Jul 10, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

cds-text~='code' have larger than surrounding font size text.

Issue Number: CDE-1660

What is the new behavior?

cds-text~='code' have same as the than surrounding font size text.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov requested a review from a team July 10, 2024 14:08
@valentin-mladenov valentin-mladenov self-assigned this Jul 10, 2024
Copy link

github-actions bot commented Jul 10, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

Copy link
Member

@kevinbuhmann kevinbuhmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine, but the PR title should be reworded. If I saw "fix(typography): cds code rule height" in the changelog, I would not know what the change is without looking the code. This would be better:

fix(typography): use surrounding font size for inline code

@valentin-mladenov valentin-mladenov changed the title fix(typography): cds code rule height fix(typography): use surrounding font size for inline code Jul 11, 2024
@valentin-mladenov
Copy link
Contributor Author

@kevinbuhmann PR title and description corrected.

@valentin-mladenov valentin-mladenov merged commit 64f8476 into main Jul 11, 2024
2 checks passed
@valentin-mladenov valentin-mladenov deleted the code-larger-than-text_cde-1660 branch July 11, 2024 12:27
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants