Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(token): update color alias tokens #337

Merged
merged 8 commits into from
Oct 25, 2024

Conversation

valentin-mladenov
Copy link
Contributor

@valentin-mladenov valentin-mladenov commented Oct 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Light and dark themes are using the same color --cds-global-color-cool-gray-50 for --cds-alias-viz-border.
Light theme have --cds-global-color-tangerine-700 for --cds-alias-viz-immediate.
Light theme have --cds-global-color-construction-200 for --cds-alias-object-container-background-dark.
Dark theme have --cds-global-color-construction-700 for --cds-alias-object-container-background-dark.

Issue Number: CDE-2387

What is the new behavior?

Light theme have --cds-global-color-construction-1100 for --cds-alias-viz-border.
Light theme have --cds-global-color-tangerine-400 for --cds-alias-viz-immediate.
Light theme have --cds-global-color-cool-gray-50 for --cds-alias-object-container-background-dark.
Dark theme have --cds-global-color-construction-1100 for --cds-alias-object-container-background-dark.
Rename --cds-alias-object-vertical-navigation-background-color tokens to cds-alias-object-interaction-background-shade.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov requested a review from a team October 23, 2024 10:27
@valentin-mladenov valentin-mladenov self-assigned this Oct 23, 2024
Copy link

github-actions bot commented Oct 23, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@valentin-mladenov valentin-mladenov changed the title fix(token): viz border light theme fix(token): update alias viz tokens Oct 24, 2024
@valentin-mladenov valentin-mladenov changed the title fix(token): update alias viz tokens fix(token): update color alias tokens Oct 25, 2024
@valentin-mladenov valentin-mladenov merged commit c8684a4 into main Oct 25, 2024
1 check passed
@valentin-mladenov valentin-mladenov deleted the correct-viz-border-light-theme_cde-2387 branch October 25, 2024 14:28
Copy link

🎉 This PR is included in version 6.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants