-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(token): update color alias tokens #337
Merged
valentin-mladenov
merged 8 commits into
main
from
correct-viz-border-light-theme_cde-2387
Oct 25, 2024
Merged
fix(token): update color alias tokens #337
valentin-mladenov
merged 8 commits into
main
from
correct-viz-border-light-theme_cde-2387
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
valentin-mladenov
changed the title
fix(token): viz border light theme
fix(token): update alias viz tokens
Oct 24, 2024
valentin-mladenov
changed the title
fix(token): update alias viz tokens
fix(token): update color alias tokens
Oct 25, 2024
14 tasks
dtsanevmw
approved these changes
Oct 25, 2024
🎉 This PR is included in version 6.14.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Light and dark themes are using the same color
--cds-global-color-cool-gray-50
for--cds-alias-viz-border
.Light theme have
--cds-global-color-tangerine-700
for--cds-alias-viz-immediate
.Light theme have
--cds-global-color-construction-200
for--cds-alias-object-container-background-dark
.Dark theme have
--cds-global-color-construction-700
for--cds-alias-object-container-background-dark
.Issue Number: CDE-2387
What is the new behavior?
Light theme have
--cds-global-color-construction-1100
for--cds-alias-viz-border
.Light theme have
--cds-global-color-tangerine-400
for--cds-alias-viz-immediate
.Light theme have
--cds-global-color-cool-gray-50
for--cds-alias-object-container-background-dark
.Dark theme have
--cds-global-color-construction-1100
for--cds-alias-object-container-background-dark
.Rename
--cds-alias-object-vertical-navigation-background-color
tokens tocds-alias-object-interaction-background-shade
.Does this PR introduce a breaking change?
Other information