Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): combobox - aria-describedby error is not associated initially (backport to 16.x) #1319

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

andyfeds
Copy link
Contributor

Combobox - aria-describedby error is not associated initially - backport fix to 16.x

  • CDE-794 A11y Clarity Combobox > aria-describedby error is not associated initially

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-794

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Backporting #1318 to 16.x manually as storybook is upgraded to CSF v3 in main.

…lly - backport to 16.x

- CDE-794 A11y Clarity Combobox > aria-describedby error is not associated initially
Signed-off-by: Andrea Fernandes <andrea.fernandes@broadcom.com>
Copy link
Contributor

github-actions bot commented Mar 15, 2024

👋 @andyfeds,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

This PR introduces visual changes: 50e21bd
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout a11y/CDE-794-16.x
git fetch https://github.com/vmware-clarity/ng-clarity.git 50e21bd5056fd5ab932357f0dd1c91330135da99
git cherry-pick 50e21bd5056fd5ab932357f0dd1c91330135da99
git push

@andyfeds andyfeds merged commit f1fcbc4 into vmware-clarity:16.x Mar 15, 2024
7 checks passed
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants