Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): datepicker - screen reader is reading extra information on opening #1322

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix(a11y): datepicker - screen reader is reading extra information on opening #1322

merged 1 commit into from
Mar 26, 2024

Conversation

andyfeds
Copy link
Contributor

A11y Clarity Datepicker - Screen reader is reading extra information upon opening

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Extra date information is announced after the date is announced the first time by the screen reader i.e the date is announced twice when the Datepicker dialog is opened.

Issue Number: CDE-790 & VPAT-21915

What is the new behavior?

The date is announced only once by the screen reader when the Datepicker is opened.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This is observed in NVDA on windows in Chrome/ IE & Firefox.

@andyfeds andyfeds self-assigned this Mar 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024 •
edited
Loading

👋 @andyfeds,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@andyfeds andyfeds requested review from a team and sandeepkulki March 20, 2024 11:33
sandeepkulki
sandeepkulki approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@sandeepkulki sandeepkulki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review is done

@andyfeds
fix(a11y): datepicker-screen reader is reading extra information upon…
771073b 
… opening

- CDE-790

Authored-by: Andrea Fernandes <andrea.fernandes@broadcom.com>
@andyfeds andyfeds merged commit 27d741a into vmware-clarity:main Mar 26, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
@andyfeds @github-actions
fix(a11y): datepicker - screen reader is reading extra information on…
a6c7173 
… opening (#1322)

A11y Clarity Datepicker - Screen reader is reading extra information
upon opening

## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
Extra date information is announced after the date is announced the
first time by the screen reader i.e the date is announced twice when the
Datepicker dialog is opened.

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: [CDE-790](https://jira.eng.vmware.com/browse/CDE-790) &
[VPAT-21915](https://jira.eng.vmware.com/browse/VPAT-21915)

## What is the new behavior?
The date is announced only once by the screen reader when the Datepicker
is opened.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information
This is observed in NVDA on windows in Chrome/ IE & Firefox.

Co-authored-by: Andrea Fernandes <andreaf1@vmware.com>
(cherry picked from commit 27d741a)
@github-actions github-actions bot mentioned this pull request Mar 26, 2024
Merged
13 tasks
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
@andyfeds @github-actions
fix(a11y): datepicker - screen reader is reading extra information on…
9b46e5b 
… opening (#1322)

A11y Clarity Datepicker - Screen reader is reading extra information
upon opening

## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
Extra date information is announced after the date is announced the
first time by the screen reader i.e the date is announced twice when the
Datepicker dialog is opened.

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: [CDE-790](https://jira.eng.vmware.com/browse/CDE-790) &
[VPAT-21915](https://jira.eng.vmware.com/browse/VPAT-21915)

## What is the new behavior?
The date is announced only once by the screen reader when the Datepicker
is opened.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information
This is observed in NVDA on windows in Chrome/ IE & Firefox.

Co-authored-by: Andrea Fernandes <andreaf1@vmware.com>
(cherry picked from commit 27d741a)
@github-actions github-actions bot mentioned this pull request Mar 26, 2024
Merged
13 tasks
andyfeds added a commit that referenced this pull request Mar 26, 2024
@github-actions @andyfeds
fix(a11y): datepicker - screen reader is reading extra information on…
5a8eebf 
… opening (backport to 15.x) (#1335)

Backport 27d741a from #1322. <br> A11y
Clarity Datepicker - Screen reader is reading extra information upon
opening

## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

&lt;!-- Please check the one that applies to this PR using
&quot;x&quot;. --&gt;

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
Extra date information is announced after the date is announced the
first time by the screen reader i.e the date is announced twice when the
Datepicker dialog is opened.

&lt;!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. --&gt;

Issue Number: [CDE-790](https://jira.eng.vmware.com/browse/CDE-790)
&amp; [VPAT-21915](https://jira.eng.vmware.com/browse/VPAT-21915)

## What is the new behavior?
The date is announced only once by the screen reader when the Datepicker
is opened.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

&lt;!-- If this PR contains a breaking change, please describe the
impact and migration path for existing applications below. --&gt;

## Other information
This is observed in NVDA on windows in Chrome/ IE &amp; Firefox.

Co-authored-by: Andrea A Fernandes <andy2890@gmail.com>
andyfeds added a commit that referenced this pull request Mar 26, 2024
@github-actions @andyfeds
fix(a11y): datepicker - screen reader is reading extra information on…
6ca101e 
… opening (backport to 16.x) (#1336)

Backport 27d741a from #1322. <br> A11y
Clarity Datepicker - Screen reader is reading extra information upon
opening

## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

&lt;!-- Please check the one that applies to this PR using
&quot;x&quot;. --&gt;

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
Extra date information is announced after the date is announced the
first time by the screen reader i.e the date is announced twice when the
Datepicker dialog is opened.

&lt;!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. --&gt;

Issue Number: [CDE-790](https://jira.eng.vmware.com/browse/CDE-790)
&amp; [VPAT-21915](https://jira.eng.vmware.com/browse/VPAT-21915)

## What is the new behavior?
The date is announced only once by the screen reader when the Datepicker
is opened.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

&lt;!-- If this PR contains a breaking change, please describe the
impact and migration path for existing applications below. --&gt;

## Other information
This is observed in NVDA on windows in Chrome/ IE &amp; Firefox.

Co-authored-by: Andrea A Fernandes <andy2890@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandeepkulki sandeepkulki sandeepkulki approved these changes

Assignees

@andyfeds andyfeds

Labels
auto-backport-to-15.x auto-backport-to-16.x cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyfeds @sandeepkulki @vmwclabot