Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): stepper-completed step does not have accessible notification after completion #1334

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

andyfeds
Copy link
Contributor

@andyfeds andyfeds commented Mar 26, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

In the Stepper, when the step is complete, keyboard focus moves to the next step but there's no indication that the previous step is completed by the screen reader.

Issue Number: CDE-699

What is the new behavior?

The screen reader will announce that the current step is complete (or failed) and move focus to the next step or stay in the same step in case of an error.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Mar 26, 2024

👋 @andyfeds,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@mivaylo
Copy link
Contributor

mivaylo commented Mar 26, 2024

Do we intend to backport this to v16? and to v15 if we do it before 28th of March (this is the end of support date for v15)?

@mivaylo
Copy link
Contributor

mivaylo commented Mar 26, 2024

Do we intend to backport this to v16? and to v15 if we do it before 28th of March (this is the end of support date for v15)?

although we are adding new API - so this seems more like a "feat" rather than a "fix" to me, but it still is not a breaking change, so it could be backported

@andyfeds
Copy link
Contributor Author

Do we intend to backport this to v16? and to v15 if we do it before 28th of March (this is the end of support date for v15)?

although we are adding new API - so this seems more like a "feat" rather than a "fix" to me, but it still is not a breaking change, so it could be backported

Yeah, its not a breaking change, just changes the behaviour for screen readers.

@andyfeds andyfeds force-pushed the a11y/CDE-699 branch 3 times, most recently from 3d2a460 to daeca79 Compare April 1, 2024 05:31
Andrea Fernandes added 6 commits April 4, 2024 10:48
…tion after completion

- CDE-699

Authored-by: Andrea Fernandes <andrea.fernandes@broadcom.com>
Authored-by: Andrea Fernandes <andrea.fernandes@broadcom.com>
Authored-by: Andrea Fernandes <andrea.fernandes@broadcom.com>
@andyfeds andyfeds merged commit 0c02a7a into vmware-clarity:main Apr 4, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
…on after completion (#1334)

## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
In the Stepper, when the step is complete, keyboard focus moves to the
next step but there's no indication that the previous step is completed
by the screen reader.
<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: [CDE-699](https://jira.eng.vmware.com/browse/CDE-699)

## What is the new behavior?
The screen reader will announce that the current step is complete (or
failed) and move focus to the next step or stay in the same step in case
of an error.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

---------

Co-authored-by: Andrea Fernandes <andreaf1@vmware.com>
(cherry picked from commit 0c02a7a)
Copy link
Contributor

github-actions bot commented Apr 4, 2024

The backport to 16.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-16.x 16.x
# Navigate to the new working tree
cd .worktrees/backport-16.x
# Create a new branch
git switch --create backport-1334-to-16.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0c02a7a2478763f9bc711d526a9ef9f81ffc6bc8
# Push it to GitHub
git push --set-upstream origin backport-1334-to-16.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-16.x

Then, create a pull request where the base branch is 16.x and the compare/head branch is backport-1334-to-16.x.

andyfeds added a commit that referenced this pull request Apr 4, 2024
…on after completion (backport to 15.x) (#1347)

Backport 0c02a7a from #1334. <br> ## PR
Checklist

Please check if your PR fulfills the following requirements:

- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

&lt;!-- Please check the one that applies to this PR using
&quot;x&quot;. --&gt;

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
In the Stepper, when the step is complete, keyboard focus moves to the
next step but there&#39;s no indication that the previous step is
completed by the screen reader.
&lt;!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. --&gt;

Issue Number: [CDE-699](https://jira.eng.vmware.com/browse/CDE-699)

## What is the new behavior?
The screen reader will announce that the current step is complete (or
failed) and move focus to the next step or stay in the same step in case
of an error.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

&lt;!-- If this PR contains a breaking change, please describe the
impact and migration path for existing applications below. --&gt;

## Other information

Co-authored-by: Andrea A Fernandes <andy2890@gmail.com>
andyfeds added a commit to andyfeds/ng-clarity that referenced this pull request Apr 4, 2024
…on after completion (vmware-clarity#1334)

Please check if your PR fulfills the following requirements:

- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

In the Stepper, when the step is complete, keyboard focus moves to the
next step but there's no indication that the previous step is completed
by the screen reader.
<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: [CDE-699](https://jira.eng.vmware.com/browse/CDE-699)

The screen reader will announce that the current step is complete (or
failed) and move focus to the next step or stay in the same step in case
of an error.

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

---------

Co-authored-by: Andrea Fernandes <andreaf1@vmware.com>
(cherry picked from commit 0c02a7a)
andyfeds added a commit that referenced this pull request Apr 4, 2024
…on after completion (#1334) (#1348)

## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

In the Stepper, when the step is complete, keyboard focus moves to the
next step but there's no indication that the previous step is completed
by the screen reader.
<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: [CDE-699](https://jira.eng.vmware.com/browse/CDE-699)

The screen reader will announce that the current step is complete (or
failed) and move focus to the next step or stay in the same step in case
of an error.

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

---------

Co-authored-by: Andrea Fernandes <andreaf1@vmware.com>

---------

Co-authored-by: Andrea Fernandes <andreaf1@vmware.com>
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants