Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): hide scrollbar if not needed #1365

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

kanthvallampati
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-451

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Apr 17, 2024

👋 @kanthvallampati,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@kanthvallampati kanthvallampati self-assigned this Apr 17, 2024
@valentin-mladenov valentin-mladenov requested a review from a team April 17, 2024 12:23
@dtsanevmw dtsanevmw changed the title fix(combobox): scrollbar gap when no scrollbar is needed fix(combobox): hide scrollbar if not needed Apr 17, 2024
@kanthvallampati kanthvallampati merged commit 8595a17 into main Apr 17, 2024
9 checks passed
@kanthvallampati kanthvallampati deleted the kanth/CDE-451 branch April 17, 2024 12:50
Copy link
Contributor

github-actions bot commented May 2, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants