-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): aria-label in datagrid header is not announced by screen reader #1386
Conversation
👋 @andyfeds,
Thank you, 🤖 Clarity Release Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screen reader fix validated
…eader (#1386) ## PR Checklist Please check if your PR fulfills the following requirements: - [x] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: [CDE-252](https://jira.eng.vmware.com/browse/CDE-252) ## What is the new behavior? Removed the aria-label and added clr-sr-only text, which is now announced by the screenreader in NVDA browse mode. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information Also fixed issue related to [CDE-1411](https://jira.eng.vmware.com/browse/CDE-1411), for v17. It was fixed only for v15 & v16 previously. --------- Co-authored-by: Andrea Fernandes <andreaf1@vmware.com> (cherry picked from commit 9e9b48d)
…eader (backport to 16.x) (#1390) Backport 9e9b48d from #1386. <br> ## PR Checklist Please check if your PR fulfills the following requirements: - [x] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: [CDE-252](https://jira.eng.vmware.com/browse/CDE-252) ## What is the new behavior? Removed the aria-label and added clr-sr-only text, which is now announced by the screenreader in NVDA browse mode. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information Also fixed issue related to [CDE-1411](https://jira.eng.vmware.com/browse/CDE-1411), for v17. It was fixed only for v15 & v16 previously. Co-authored-by: Andrea A Fernandes <andy2890@gmail.com>
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: CDE-252
What is the new behavior?
Removed the aria-label and added clr-sr-only text, which is now announced by the screenreader in NVDA browse mode.
Does this PR introduce a breaking change?
Other information
Also fixed issue related to CDE-1411, for v17. It was fixed only for v15 & v16 previously.