fix(modal): fall back to modal id for dialog aria-labelledby attribute
#1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
kevinbuhmann
changed the title
kevinbuhmann
changed the title
aria-labelledby attribute
kevinbuhmann
force-pushed
the
kevin/modal-labelledby
branch
from
7d8c34b
to
104cfa3
Compare
github-actions bot
pushed a commit
that referenced
this pull request
May 29, 2024
…ute (#1403) ## What is the current behavior? If you set `[clrModalLabelledById]` to an empty string, the `aria-labelledby` attribute of the modal dialog element is set to an empty value. This behavior can be seen in the modal stories since the input is defaulted to an empty string. We can't default it to the modal id because that is not known until the component is instantiated. Issue Number: CDE-2050 ## What is the new behavior? If you set `[clrModalLabelledById]` to an empty string, the `aria-labelledby` attribute of the modal dialog element is set to the modal id. (cherry picked from commit 6493dc3)
Merged
1 task
Jinnie
pushed a commit
that referenced
this pull request
May 29, 2024
…ute (#1403) If you set `[clrModalLabelledById]` to an empty string, the `aria-labelledby` attribute of the modal dialog element is set to an empty value. This behavior can be seen in the modal stories since the input is defaulted to an empty string. We can't default it to the modal id because that is not known until the component is instantiated. Issue Number: CDE-2050 If you set `[clrModalLabelledById]` to an empty string, the `aria-labelledby` attribute of the modal dialog element is set to the modal id. (cherry picked from commit 6493dc3)
Jinnie
pushed a commit
that referenced
this pull request
May 29, 2024
…ute (backport to 16.x) (#1407) Backport 6493dc3 from #1403. <br> ## PR Checklist - [x] Tests for the changes have been added (for bug fixes / features) - [N/A] Docs have been added / updated (for bug fixes / features) - [N/A] If applicable, have a visual design approval ## PR Type Bugfix ## What is the current behavior? If you set `[clrModalLabelledById]` to an empty string, the `aria-labelledby` attribute of the modal dialog element is set to an empty value. This behavior can be seen in the modal stories since the input is defaulted to an empty string. We can't default it to the modal id because that is not known until the component is instantiated. Issue Number: CDE-2050 ## What is the new behavior? If you set `[clrModalLabelledById]` to an empty string, the `aria-labelledby` attribute of the modal dialog element is set to the modal id. ## Does this PR introduce a breaking change? No. Co-authored-by: Kevin Buhmann <kbuhmann@vmware.com>
|
🎉 This PR is included in version 17.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Bugfix
What is the current behavior?
If you set
[clrModalLabelledById]to an empty string, thearia-labelledbyattribute of the modal dialog element is set to an empty value.This behavior can be seen in the modal stories since the input is defaulted to an empty string. We can't default it to the modal id because that is not known until the component is instantiated.
Issue Number: CDE-2050
What is the new behavior?
If you set
[clrModalLabelledById]to an empty string, thearia-labelledbyattribute of the modal dialog element is set to the modal id.Does this PR introduce a breaking change?
No.