fix(modal): fall back to modal id for dialog aria-labelledby
attribute (backport to 16.x)
#1407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6493dc3 from #1403.
## PR Checklist
PR Type
Bugfix
What is the current behavior?
If you set
[clrModalLabelledById]
to an empty string, thearia-labelledby
attribute of the modal dialog element is set to an empty value.This behavior can be seen in the modal stories since the input is defaulted to an empty string. We can't default it to the modal id because that is not known until the component is instantiated.
Issue Number: CDE-2050
What is the new behavior?
If you set
[clrModalLabelledById]
to an empty string, thearia-labelledby
attribute of the modal dialog element is set to the modal id.Does this PR introduce a breaking change?
No.