fix(a11y): return focus to datagrid detail pane toggle button after esc with zoom 250% #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 29, 2024 14:32
|
👋 @andyfeds,
Thank you, 🤖 Clarity Release Bot |
sandeepkulki
approved these changes
May 29, 2024
sandeepkulki
approved these changes
May 29, 2024
kevinbuhmann
requested changes
May 29, 2024
@kevinbuhmann this is a fix for a specific case where in the detail pane is closed using "ESC" key, the code needed to be moved into the service to fix it. It's needed. Let me know if i still need to refactor the title/summary. |
Ah, I see. It appeared to be just a refactor, but the modal stack uses the service? I understand now. |
kevinbuhmann
approved these changes
May 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2024
…sc with zoom 250% (#1408) ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: [CDE-2051](https://jira.eng.vmware.com/browse/CDE-2051) ## What is the new behavior? Focus is returned to the button that opened the pane on ESC key in zoom more than 250%. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information --------- Co-authored-by: Andrea Fernandes <andreaf1@vmware.com> (cherry picked from commit b4d4548)
13 tasks
andyfeds
added a commit
that referenced
this pull request
May 30, 2024
…sc with zoom 250% (backport to 16.x) (#1413) Backport b4d4548 from #1408. <br> ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: [CDE-2051](https://jira.eng.vmware.com/browse/CDE-2051) ## What is the new behavior? Focus is returned to the button that opened the pane on ESC key in zoom more than 250%. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information Co-authored-by: Andrea A Fernandes <andy2890@gmail.com>
|
🎉 This PR is included in version 17.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: CDE-2051
What is the new behavior?
Focus is returned to the button that opened the pane on ESC key in zoom more than 250%.
Does this PR introduce a breaking change?
Other information