fix(file-input): add vertical spacing between label and browse button #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also removes dead `.clr-control-label` styles. The label is not nested in the wrapper.
Thank you, 🤖 Clarity Release Bot |
This comment was marked as resolved.
This comment was marked as resolved.
dtsanevmw
approved these changes
May 30, 2024
valentin-mladenov
approved these changes
May 30, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-16.x 16.x
# Navigate to the new working tree
cd .worktrees/backport-16.x
# Create a new branch
git switch --create backport-1415-to-16.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e378c6092db054fe8fddcc029e674f0e19988df2
# Push it to GitHub
git push --set-upstream origin backport-1415-to-16.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-16.xThen, create a pull request where the |
kevinbuhmann
added a commit
that referenced
this pull request
May 30, 2024
|
🎉 This PR is included in version 17.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if your PR fulfills the following requirements:
PR Type
Bugfix
What is the current behavior?
No vertical spacing between the label and an the browse button.
Issue Number: CDE-1668
What is the new behavior?
Vertical spacing between the label and an the browse button.
Does this PR introduce a breaking change?
No.
Other Information
This commit also removes dead
.clr-control-labelstyles. The label is not nested in the wrapper. That is why I didn't add the margin on the label.