Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datagrid): hide sticky columns for loading more items row #1420

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

dtsanevmw
Copy link
Contributor

@dtsanevmw dtsanevmw commented Jun 3, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently loading rows are using clr-dg-row which shows the sticky columns if available
Screenshot 2024-06-03 at 23 53 10

Issue Number: CDE-2069

What is the new behavior?

Hide sticky columns for loading row.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@dtsanevmw dtsanevmw requested a review from a team June 3, 2024 20:53
@dtsanevmw dtsanevmw self-assigned this Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/hide_sticky_columns_for_loading_row branch from 9895c77 to aaf2d89 Compare June 5, 2024 08:14
@dtsanevmw dtsanevmw merged commit f856ab6 into main Jun 6, 2024
7 checks passed
@dtsanevmw dtsanevmw deleted the dtsanevmw/hide_sticky_columns_for_loading_row branch June 6, 2024 13:32
Copy link
Contributor

github-actions bot commented Jun 6, 2024

The backport to 16.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-16.x 16.x
# Navigate to the new working tree
cd .worktrees/backport-16.x
# Create a new branch
git switch --create backport-1420-to-16.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f856ab6a16320da4f01820ad5008568b2e4aecf8
# Push it to GitHub
git push --set-upstream origin backport-1420-to-16.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-16.x

Then, create a pull request where the base branch is 16.x and the compare/head branch is backport-1420-to-16.x.

dtsanevmw added a commit that referenced this pull request Jun 10, 2024
Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [X] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

Currently loading rows are using `clr-dg-row` which shows the sticky
columns if available
![Screenshot 2024-06-03 at 23 53
10](https://github.com/vmware-clarity/ng-clarity/assets/127101685/0fb09866-ea69-4679-9d8f-d1a691ae4a65)

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: CDE-2069

Hide sticky columns for loading row.

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->
(cherry picked from commit f856ab6)
dtsanevmw added a commit that referenced this pull request Jun 10, 2024
Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [X] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

Currently loading rows are using `clr-dg-row` which shows the sticky
columns if available
![Screenshot 2024-06-03 at 23 53
10](https://github.com/vmware-clarity/ng-clarity/assets/127101685/0fb09866-ea69-4679-9d8f-d1a691ae4a65)

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: CDE-2069

Hide sticky columns for loading row.

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->
dtsanevmw added a commit that referenced this pull request Jun 10, 2024
…#1430)

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [X] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

Currently loading rows are using `clr-dg-row` which shows the sticky
columns if available
![Screenshot 2024-06-03 at 23 53

10](https://github.com/vmware-clarity/ng-clarity/assets/127101685/0fb09866-ea69-4679-9d8f-d1a691ae4a65)

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: CDE-2069

Hide sticky columns for loading row.

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: N/A

## What is the new behavior?

## Does this PR introduce a breaking change?

- [ ] Yes
- [ ] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants