-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datagrid): hide sticky columns for loading more items row #1420
Conversation
👋 @dtsanevmw,
Thank you, 🤖 Clarity Release Bot |
9895c77
to
aaf2d89
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-16.x 16.x
# Navigate to the new working tree
cd .worktrees/backport-16.x
# Create a new branch
git switch --create backport-1420-to-16.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f856ab6a16320da4f01820ad5008568b2e4aecf8
# Push it to GitHub
git push --set-upstream origin backport-1420-to-16.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-16.x Then, create a pull request where the |
Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: Currently loading rows are using `clr-dg-row` which shows the sticky columns if available ![Screenshot 2024-06-03 at 23 53 10](https://github.com/vmware-clarity/ng-clarity/assets/127101685/0fb09866-ea69-4679-9d8f-d1a691ae4a65) <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-2069 Hide sticky columns for loading row. - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> (cherry picked from commit f856ab6)
Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: Currently loading rows are using `clr-dg-row` which shows the sticky columns if available ![Screenshot 2024-06-03 at 23 53 10](https://github.com/vmware-clarity/ng-clarity/assets/127101685/0fb09866-ea69-4679-9d8f-d1a691ae4a65) <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-2069 Hide sticky columns for loading row. - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
…#1430) Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: Currently loading rows are using `clr-dg-row` which shows the sticky columns if available ![Screenshot 2024-06-03 at 23 53 10](https://github.com/vmware-clarity/ng-clarity/assets/127101685/0fb09866-ea69-4679-9d8f-d1a691ae4a65) <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-2069 Hide sticky columns for loading row. - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: N/A ## What is the new behavior? ## Does this PR introduce a breaking change? - [ ] Yes - [ ] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently loading rows are using
clr-dg-row
which shows the sticky columns if availableIssue Number: CDE-2069
What is the new behavior?
Hide sticky columns for loading row.
Does this PR introduce a breaking change?
Other information