Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signpost): vertical overflow and long content pointer position #1503

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

valentin-mladenov
Copy link
Contributor

@valentin-mladenov valentin-mladenov commented Aug 5, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

  • Vertical overflow is seen when it shouldn't be.
  • Pointer position in vertical plane is wrong when long content is loaded.

Issue Number: CDE-2225, CDE-2226

What is the new behavior?

  • Vertical overflow is seen only when max height is reached.
  • Pointer position in vertical plane point to the trigger every time.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov requested a review from a team August 5, 2024 09:40
@valentin-mladenov valentin-mladenov self-assigned this Aug 5, 2024
@valentin-mladenov valentin-mladenov marked this pull request as ready for review August 5, 2024 09:40
Copy link
Contributor

github-actions bot commented Aug 5, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This PR introduces visual changes: 219bcaf
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout signpost-bugs_cde-2225_cdde-2226
git fetch https://github.com/vmware-clarity/ng-clarity.git 219bcafa4165f018e264c4a520dc872a60f589a6
git cherry-pick 219bcafa4165f018e264c4a520dc872a60f589a6
git push

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This PR introduces visual changes: 20bb366
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout signpost-bugs_cde-2225_cdde-2226
git fetch https://github.com/vmware-clarity/ng-clarity.git 20bb366b17a3367a2f091bf85cadef9d39b6db21
git cherry-pick 20bb366b17a3367a2f091bf85cadef9d39b6db21
git push

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This PR introduces visual changes: 294b0d6
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout signpost-bugs_cde-2225_cdde-2226
git fetch https://github.com/vmware-clarity/ng-clarity.git 294b0d695bb94e961f42fa78b19f69a66676257d
git cherry-pick 294b0d695bb94e961f42fa78b19f69a66676257d
git push

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This PR introduces visual changes: 6fd1b9b
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout signpost-bugs_cde-2225_cdde-2226
git fetch https://github.com/vmware-clarity/ng-clarity.git 6fd1b9beb8ebaf7213ae2527c151613ed8e5b8ec
git cherry-pick 6fd1b9beb8ebaf7213ae2527c151613ed8e5b8ec
git push

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This PR introduces visual changes: e4a678b
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout signpost-bugs_cde-2225_cdde-2226
git fetch https://github.com/vmware-clarity/ng-clarity.git e4a678b2029b5303e01e99fa73f185a9d48b3a31
git cherry-pick e4a678b2029b5303e01e99fa73f185a9d48b3a31
git push

@valentin-mladenov valentin-mladenov merged commit cd57050 into main Aug 6, 2024
8 checks passed
@valentin-mladenov valentin-mladenov deleted the signpost-bugs_cde-2225_cdde-2226 branch August 6, 2024 09:10
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants