Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datagrid): opened details missing vertical separator (backport to 16.x) #1516

Conversation

valentin-mladenov
Copy link
Contributor

Backport 63da5a5 from #1493.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Vertical border between opened details and datagrid rows doesn't extend to bottom.

Issue Number: CDE-2188

What is the new behavior?

Vertical border between opened details and datagrid rows extend to bottom.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

image

@valentin-mladenov valentin-mladenov requested a review from a team August 9, 2024 11:04
@valentin-mladenov valentin-mladenov self-assigned this Aug 9, 2024
@valentin-mladenov valentin-mladenov marked this pull request as ready for review August 9, 2024 11:04
Copy link
Contributor

github-actions bot commented Aug 9, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

github-actions bot commented Aug 9, 2024

This PR introduces visual changes: caea603
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout datagrid-missing-vertical-border_cde-2188_backport-16.x
git fetch https://github.com/vmware-clarity/ng-clarity.git caea603c571151220e84b762142892c00bf79111
git cherry-pick caea603c571151220e84b762142892c00bf79111
git push

Copy link
Contributor

github-actions bot commented Aug 9, 2024

This PR introduces visual changes: 63ac8b0
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout datagrid-missing-vertical-border_cde-2188_backport-16.x
git fetch https://github.com/vmware-clarity/ng-clarity.git 63ac8b0bf45778efdeec2ca5928d6b1c764b8c45
git cherry-pick 63ac8b0bf45778efdeec2ca5928d6b1c764b8c45
git push

@valentin-mladenov valentin-mladenov merged commit 7149e62 into 16.x Aug 9, 2024
7 checks passed
@valentin-mladenov valentin-mladenov deleted the datagrid-missing-vertical-border_cde-2188_backport-16.x branch August 9, 2024 13:20
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants