Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion,stepper): adjust panel title width to align panel descriptions #1524

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

kevinbuhmann
Copy link
Member

CDE-2220

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

Bugfix

What is the current behavior?

Accordion and stepper panel description text was not aligned vertically.

Issue Number: CDE-2220

What is the new behavior?

Accordion and stepper panel description text is aligned vertically.

Does this PR introduce a breaking change?

No.

@kevinbuhmann kevinbuhmann requested a review from a team August 28, 2024 16:15
@kevinbuhmann kevinbuhmann self-assigned this Aug 28, 2024
Copy link
Contributor

github-actions bot commented Aug 28, 2024

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

This comment was marked as resolved.

Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comment.

projects/angular/src/accordion/_accordion.clarity.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbuhmann kevinbuhmann merged commit 2b021b0 into main Sep 4, 2024
8 checks passed
@kevinbuhmann kevinbuhmann deleted the kevin/accordion-alignment branch September 4, 2024 13:45
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants