Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stack-view): align content with label #1534

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

valentin-mladenov
Copy link
Contributor

@valentin-mladenov valentin-mladenov commented Aug 30, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Stack view block content and label are misaligned by few pixels between different types of blocks.

Issue Number: CDE-2266

What is the new behavior?

Stack view block content and label are aligned for all types of blocks.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

image

Copy link
Contributor

github-actions bot commented Aug 30, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

This PR introduces visual changes: 0ae5f5b
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout stack-view-content-misalignment_cde-2266
git fetch https://github.com/vmware-clarity/ng-clarity.git 0ae5f5b84b6e539dfa1ba5b9bf5b23b57ee85be7
git cherry-pick 0ae5f5b84b6e539dfa1ba5b9bf5b23b57ee85be7
git push

@valentin-mladenov valentin-mladenov marked this pull request as ready for review August 30, 2024 13:14
@valentin-mladenov valentin-mladenov requested a review from a team August 30, 2024 13:14
Copy link
Contributor

github-actions bot commented Sep 3, 2024

This PR introduces visual changes: b7f513a
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout stack-view-content-misalignment_cde-2266
git fetch https://github.com/vmware-clarity/ng-clarity.git b7f513ac051b36c086889efdf390ce4641067aae
git cherry-pick b7f513ac051b36c086889efdf390ce4641067aae
git push

@kevinbuhmann
Copy link
Member

This looks like a fix for vertical alignment, not horizontal alignment. I think the PR title and summary should be reworded.

@valentin-mladenov valentin-mladenov changed the title fix(stack-view): content horizontal alignment fix(stack-view): alignment between label and content Sep 4, 2024
@valentin-mladenov valentin-mladenov changed the title fix(stack-view): alignment between label and content fix(stack-view): align content with label Sep 4, 2024
@valentin-mladenov valentin-mladenov merged commit bd6a994 into main Sep 4, 2024
8 checks passed
@valentin-mladenov valentin-mladenov deleted the stack-view-content-misalignment_cde-2266 branch September 4, 2024 14:24
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants