Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): input control container typography #1543

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Input container typography is relative to parent.

Issue Number: CDE-2233

What is the new behavior?

Input container typography is using design typography token SECONDARY-13-RG-EXP.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov self-assigned this Sep 5, 2024
@valentin-mladenov valentin-mladenov requested a review from a team September 5, 2024 07:26
@valentin-mladenov valentin-mladenov marked this pull request as ready for review September 5, 2024 07:26
Copy link
Contributor

github-actions bot commented Sep 5, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

github-actions bot commented Sep 5, 2024

This PR introduces visual changes: 68acf5a
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout form-input-control-typography_cde-2233
git fetch https://github.com/vmware-clarity/ng-clarity.git 68acf5a9c301171f9007f07ce61218eb2aa7a5ce
git cherry-pick 68acf5a9c301171f9007f07ce61218eb2aa7a5ce
git push

Copy link
Contributor

@Jinnie Jinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
We should be careful when we release it though, because it has to many visual changes.
16 is a no-go, in 17 it could be after VCF9 release.

@valentin-mladenov
Copy link
Contributor Author

There will be no backport for this PR.

@valentin-mladenov valentin-mladenov merged commit d2a7316 into main Sep 10, 2024
8 checks passed
@valentin-mladenov valentin-mladenov deleted the form-input-control-typography_cde-2233 branch September 10, 2024 06:16
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants