Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepper): nested accordion have wrong styling and behaviour #1550

Merged

Conversation

valentin-mladenov
Copy link
Contributor

@valentin-mladenov valentin-mladenov commented Sep 9, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When nested in stepper accordion have different than specification look and feel.

  • Header is taller
  • Text is bolder
  • Have stepper number
  • Text is aligned with stepper's text

image

Issue Number: CDE-2275

What is the new behavior?

When nested in stepper accordion header have specification based styles and behaviour.
image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Sep 9, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

github-actions bot commented Sep 9, 2024

This PR introduces visual changes: 9942569
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout nested-accordion-in-stepper-wrong-height_cde-2275
git fetch https://github.com/vmware-clarity/ng-clarity.git 9942569bd2878c1a1679a2dd159c9ae56e6e6bec
git cherry-pick 9942569bd2878c1a1679a2dd159c9ae56e6e6bec
git push

Copy link
Contributor

@Jinnie Jinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting case. Looks good.

@valentin-mladenov valentin-mladenov changed the title fix(stepper): nested accordion have wrong height fix(stepper): nested accordion have wrong styling and behaviour Sep 9, 2024
@valentin-mladenov valentin-mladenov merged commit 8211acd into main Sep 10, 2024
8 checks passed
@valentin-mladenov valentin-mladenov deleted the nested-accordion-in-stepper-wrong-height_cde-2275 branch September 10, 2024 06:01
Copy link
Contributor

The backport to 16.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-16.x 16.x
# Navigate to the new working tree
cd .worktrees/backport-16.x
# Create a new branch
git switch --create backport-1550-to-16.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8211acdc2c899bcd6b322ca01207b0007f859369
# Push it to GitHub
git push --set-upstream origin backport-1550-to-16.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-16.x

Then, create a pull request where the base branch is 16.x and the compare/head branch is backport-1550-to-16.x.

Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants