Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update beta.kubernetes.io/os nodeSelector to kubernetes.io/os #361

Closed
alex-vmw opened this issue Feb 6, 2020 · 3 comments · Fixed by #512
Closed

Update beta.kubernetes.io/os nodeSelector to kubernetes.io/os #361

alex-vmw opened this issue Feb 6, 2020 · 3 comments · Fixed by #512
Assignees
@antoninbas
Labels
area/dependency Issues or PRs related to dependency changes. good first issue Good for newcomers kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
Antrea v0.5.0 rel...

Comments

@alex-vmw
Copy link

alex-vmw commented Feb 6, 2020

As per https://v1-14.docs.kubernetes.io/docs/setup/release/notes/ beta.kubernetes.io/os has been deprecated and will be completely removed in k8s 1.18. That said, please update beta.kubernetes.io/os nodeSelector to kubernetes.io/os in the antrea yml file.
@abhiraut abhiraut added this to the Antrea v0.4.0 release milestone Feb 6, 2020
@antoninbas antoninbas added the good first issue Good for newcomers label Feb 6, 2020
@McCodeman McCodeman added area/dependency Issues or PRs related to dependency changes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Feb 12, 2020
@dilan-js
Copy link

Hi all, I would like to complete this issue!
Thanks, Dilan

@McCodeman McCodeman added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Feb 26, 2020
@antoninbas
Copy link
Contributor

@dilan-js do you still intend to take a stab at this? Thanks.

@antoninbas
Copy link
Contributor

No update, so re-assigning the issue to myself to make sure it gets taken care of in time for the 0.5.0 release.

@antoninbas antoninbas assigned antoninbas and unassigned dilan-js Mar 18, 2020
antoninbas added a commit to antoninbas/antrea that referenced this issue Mar 18, 2020
@antoninbas
Update beta.kubernetes.io/os to kubernetes.io/os
f41bb7e 
Starting with K8s 1.18, beta.kubernetes.io/os is removed.
kubernetes.io/os is supported from K8s 1.14.

Fixes antrea-io#361
@antoninbas antoninbas mentioned this issue Mar 18, 2020
Merged
antoninbas added a commit that referenced this issue Mar 20, 2020
@antoninbas
Update beta.kubernetes.io/os to kubernetes.io/os
82a4c93 
Starting with K8s 1.18, beta.kubernetes.io/os is removed.
kubernetes.io/os is supported from K8s 1.14.

Fixes #361
ZhangYW18 pushed a commit to ZhangYW18/antrea that referenced this issue Mar 23, 2020
@antoninbas @ZhangYW18
Update beta.kubernetes.io/os to kubernetes.io/os
75943d8 
Starting with K8s 1.18, beta.kubernetes.io/os is removed.
kubernetes.io/os is supported from K8s 1.14.

Fixes antrea-io#361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoninbas antoninbas

Labels
area/dependency Issues or PRs related to dependency changes. good first issue Good for newcomers kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
Antrea v0.5.0 release
Development

Successfully merging a pull request may close this issue.

Update beta.kubernetes.io/os to kubernetes.io/os antoninbas/antrea
5 participants
@abhiraut @antoninbas @McCodeman @alex-vmw @dilan-js