Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Antrea interoperability with MetalLB #322

Closed
wants to merge 1 commit into from

Conversation

ksamoray
Copy link
Contributor

Add a doc describing Antrea interoperability with MetalLB loadbalancing
solution for K8S.

Add a doc describing Antrea interoperability with MetalLB loadbalancing
solution for K8S.
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there is no special consideration to keep in mind or no special configuration parameter to apply?

Is there anything special with the version you picked (v0.8.3)?

@ksamoray
Copy link
Contributor Author

So there is no special consideration to keep in mind or no special configuration parameter to apply?
Haven't applied any special config other than these which are required by MetalLB: IP range for external IPs, BGP peers etc.
These are documented in the MetalLB guide - IDK if it's wise to duplicate these into the Antrea doc which IMO should act as a reference. As MetalLB config params might change.
Is there anything special with the version you picked (v0.8.3)?
Not really, picked 8.3 as it's the latest and is the one which I tested with. Should we test other versions too? Or maybe avoid placing a version within the doc?

@ksamoray
Copy link
Contributor Author

/test-all

@jianjuns
Copy link
Contributor

jianjuns commented Feb 3, 2020

@McCodeman @salv-orlando : wonder what are your thoughts of documenting Metal LB in Antrea.

@antrea-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

These commands can only be run by members of the vmware-tanzu organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants