Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --controller-only flag for supportbundle command #791

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Add --controller-only flag for supportbundle command #791

merged 1 commit into from
Jun 6, 2020

Conversation

weiqiangt
Copy link
Contributor

@weiqiangt weiqiangt commented Jun 4, 2020 •
edited
Loading

The --controller-only flag tells the supportbundle command to only collect the support bundle of the antrea controller.

Signed-off-by: Weiqiang TANG weiqiangt@vmware.com

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

antoninbas
antoninbas reviewed Jun 5, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT but please rename the flag to --controller-only, which is more "common"

(and rename the struct field accordingly to controllerOnly)

@weiqiangt
Add --controller-only flag for supportbundle command
3a8f901 
The --controller-only flag tells the supportbundle command
to only collect the support bundle of the antrea controller.

Signed-off-by: Weiqiang TANG <weiqiangt@vmware.com>
@weiqiangt weiqiangt force-pushed the weiqiangt/antctl-supportbundle-controller-only branch from e1dd037 to 3a8f901 Compare June 5, 2020 01:29
@weiqiangt weiqiangt changed the title Add --only-controller flag for supportbundle command Add --controller-only flag for supportbundle command Jun 5, 2020
@weiqiangt
Copy link
Contributor Author

/test-all

antoninbas
antoninbas approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiqiangt weiqiangt merged commit 92097d3 into antrea-io:master Jun 6, 2020
@jianjuns jianjuns mentioned this pull request Jun 22, 2020
Merged
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@weiqiangt @GraysonWu
Add --controller-only flag for supportbundle command (antrea-io#791)
bfc7402 
The --controller-only flag tells the supportbundle command
to only collect the support bundle of the antrea controller.

Signed-off-by: Weiqiang TANG <weiqiangt@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiqiangt @antrea-bot @antoninbas @vmwclabot