Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement supportbundle command on Windows node #820

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Implement supportbundle command on Windows node #820

merged 1 commit into from
Jun 11, 2020

Conversation

weiqiangt
Copy link
Contributor

  • Use internal queriers instead of antctl to
    retrieve networkpolicies and agentinfo.
  • Change default output dir name because Windows
    does not support ':' in filename.

Signed-off-by: Weiqiang TANG weiqiangt@vmware.com

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

@weiqiangt
Copy link
Contributor Author

/test-all

@weiqiangt weiqiangt force-pushed the weiqiangt/supportbundle-windows branch from 7e2ae5b to 35e5690 Compare June 10, 2020 11:12
wenyingd
wenyingd reviewed Jun 10, 2020
View reviewed changes
pkg/apiserver/apiserver.go Outdated Show resolved Hide resolved
pkg/apiserver/registry/system/supportbundle/rest.go Outdated Show resolved Hide resolved
pkg/support/dump.go Outdated Show resolved Hide resolved
pkg/support/dump.go Show resolved Hide resolved
@weiqiangt weiqiangt force-pushed the weiqiangt/supportbundle-windows branch from 35e5690 to 84315f3 Compare June 10, 2020 13:03
@weiqiangt weiqiangt force-pushed the weiqiangt/supportbundle-windows branch 2 times, most recently from c691448 to c65dd9b Compare June 10, 2020 13:42
jianjuns
jianjuns reviewed Jun 10, 2020
View reviewed changes
Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

pkg/support/dump.go Outdated Show resolved Hide resolved
@weiqiangt
Implement supportbundle command on Windows node
bbf1115 
- Use internal queriers instead of antctl to
  retrieve networkpolicies and agentinfo.
- Change default output dir name because Windows
  does not support ':' in filename.

Signed-off-by: Weiqiang TANG <weiqiangt@vmware.com>
@weiqiangt weiqiangt force-pushed the weiqiangt/supportbundle-windows branch from c65dd9b to bbf1115 Compare June 11, 2020 03:05
@weiqiangt
Copy link
Contributor Author

/test-all

1 similar comment
@weiqiangt
Copy link
Contributor Author

/test-all

@weiqiangt
Copy link
Contributor Author

/test-windows-conformance

1 similar comment
@weiqiangt
Copy link
Contributor Author

/test-windows-conformance

wenyingd
wenyingd approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiqiangt weiqiangt merged commit e80b79d into antrea-io:master Jun 11, 2020
@weiqiangt weiqiangt deleted the weiqiangt/supportbundle-windows branch June 11, 2020 11:20
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@weiqiangt @GraysonWu
Implement supportbundle command on Windows node (antrea-io#820)
ef1cc10 
- Use internal queriers instead of antctl to
  retrieve networkpolicies and agentinfo.
- Change default output dir name because Windows
  does not support ':' in filename.

Signed-off-by: Weiqiang TANG <weiqiangt@vmware.com>
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 23, 2020
@weiqiangt @GraysonWu
Implement supportbundle command on Windows node (antrea-io#820)
68e617e 
- Use internal queriers instead of antctl to
  retrieve networkpolicies and agentinfo.
- Change default output dir name because Windows
  does not support ':' in filename.

Signed-off-by: Weiqiang TANG <weiqiangt@vmware.com>
@Atish-iaf Atish-iaf mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianjuns jianjuns jianjuns left review comments

@ruicao93 ruicao93 ruicao93 left review comments

@wenyingd wenyingd wenyingd approved these changes

@tnqn tnqn Awaiting requested review from tnqn

@antoninbas antoninbas Awaiting requested review from antoninbas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@weiqiangt @antrea-bot @ruicao93 @wenyingd @jianjuns @vmwclabot