Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support docker registry secrets for AppRepositories #1522

Closed
4 tasks done
absoludity opened this issue Feb 17, 2020 · 0 comments
Closed
4 tasks done

Support docker registry secrets for AppRepositories #1522

absoludity opened this issue Feb 17, 2020 · 0 comments

Comments

@absoludity
Copy link
Contributor

absoludity commented Feb 17, 2020

As part of implementing support for app repositories using private docker registries (#1256), we need to support linking docker registry secrets to AppRepositories. See design doc for more info and discussion.

  • Update the AppRepository resource to support the additional field dockerRegistrySecrets (a list of strings containing the names of any secrets that should be made available by the repo)
  • [UI] Enable selecting from existing dockerconfigjson secrets in the given namespace, as required for an AppRepository.
  • [UI] Enable adding new dockerconfigjson secrets while creating/editing an AppRepository
  • Ensuring that repos available in all namespaces cannot have docker registry secrets added (as the secrets are available only in the namespace of the app repository).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant