Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/migrate UI calls to Kubeops #4785

Closed
3 tasks done
antgamdia opened this issue May 25, 2022 · 3 comments · Fixed by #5239 or #5249
Closed
3 tasks done

Remove/migrate UI calls to Kubeops #4785

antgamdia opened this issue May 25, 2022 · 3 comments · Fixed by #5239 or #5249
Assignees
Labels
component/kubeops Issue related to kubeops (to be deprecated) kind/enhancement An issue that reports an enhancement for an implemented feature

Comments

@antgamdia
Copy link
Contributor

antgamdia commented May 25, 2022

Summary

As part of the analysis performed for #4764, I noticed we still have several calls to the kubeops endpoints that should be properly migrated to the Resources plugin or the PackageRepositories plugin.

Background and rationale

Once we get rid of the Kubeops calls for managing repositories, there is no reason for us to maintain Kubeops. Therefore, any remaining call should be migrated.

Description

First, further analysis of what we have to delete or migrate has to be carried out.

Acceptance criteria

Additional context

Note that, first, we have to finish the implementation of the Helm-plugin Repositories API.

@antgamdia antgamdia added the component/kubeops Issue related to kubeops (to be deprecated) label May 25, 2022
@antgamdia antgamdia added this to the App repository revamping milestone May 25, 2022
@antgamdia antgamdia moved this to 🗂 Backlog in Kubeapps May 25, 2022
@ppbaena ppbaena added the kind/enhancement An issue that reports an enhancement for an implemented feature label May 26, 2022
@ppbaena ppbaena added the next-iteration Issues to be discussed in planning session label Jun 6, 2022
@absoludity
Copy link
Contributor

Kubeops currently has the kubeops-ns-discovery ClusterRole which gives access to list the namespaces of a cluster (before they are filtered by user RBAC). We'll need to move this cluster role and apply it to the kubeapps-apis service account so that we can use it from the resources plugin for similar functionality.

@ppbaena ppbaena moved this from 🗂 Backlog to 🗒 Todo in Kubeapps Jul 4, 2022
@ppbaena ppbaena removed the next-iteration Issues to be discussed in planning session label Jul 4, 2022
@antgamdia
Copy link
Contributor Author

antgamdia commented Jul 5, 2022

For now, I have indentified:

@antgamdia antgamdia moved this from 🗒 Todo to 🏗 In Progress in Kubeapps Jul 5, 2022
@antgamdia antgamdia moved this from 🏗 In Progress to 🗒 Todo in Kubeapps Jul 5, 2022
@antgamdia antgamdia removed their assignment Jul 22, 2022
@castelblanque castelblanque self-assigned this Aug 25, 2022
@castelblanque castelblanque moved this from 🗒 Todo to 🏗 In Progress in Kubeapps Aug 29, 2022
@castelblanque
Copy link
Collaborator

For now, I have indentified

After some investigation:

  • getResource is not used and thus has been removed (pending PR)
  • getAPIGroups/getResourceKinds are direct K8s APIs calls unrelated to Kubeops. They are only used when operators are enabled.
  • canI will be moved into resources plugin (pending PR)

The only remaining endpoint in Kubeops will be a simple “give me this operator logo” (this line). Kubeops only makes a subsequent K8s API call, so no added value. Given that the call is related to operators, it will be moved to be done directly from the frontend (k8s api calls are allowed when using operators).

Repository owner moved this from 🏗 In Progress to ✅ Done in Kubeapps Aug 31, 2022
@castelblanque castelblanque moved this from ✅ Done to 🔎 In Review in Kubeapps Aug 31, 2022
@castelblanque castelblanque moved this from 🔎 In Review to ✅ Done in Kubeapps Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/kubeops Issue related to kubeops (to be deprecated) kind/enhancement An issue that reports an enhancement for an implemented feature
Projects
Archived in project
4 participants