This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
add (infra-provider) credential detection for cluster deletion #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpmcb putting this here so I don't forget for tomorrow. Let's update the init code to save the original cluster config file. Then, users won't need to specify this flag because we can load the file from a known good location. talk tomorrow 👋 |
davidvonthenen
approved these changes
May 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This introduces credential detection for providers.
Now running:
will properly delete the standalone cluster.
Most changes occurred here: https://github.com/vmware-tanzu-private/tkg-cli/commit/aecf8ddffda7b63d3653c7adfc5119670e172b43