Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

velero completion zsh can't work on macOS 12.3.1 (Apple M1 silicon) #4912

Closed
drummerglen opened this issue May 14, 2022 · 3 comments · Fixed by #4914
Closed

velero completion zsh can't work on macOS 12.3.1 (Apple M1 silicon) #4912

drummerglen opened this issue May 14, 2022 · 3 comments · Fixed by #4914
Assignees
Labels
Area/CLI related to the command-line interface

Comments

@drummerglen
Copy link

What steps did you take and what happened:
[A clear and concise description of what the bug is, and what commands you ran.)
velero completion zsh can't work on macOS 12.3.1 (Apple M1 silicon)
I have been executedsource <(velero completion zsh)
Other command completion works.
source <(kubectl completion zsh)
source <(helm completion zsh)

What did you expect to happen:
command velero + tab can work on macOS zsh environment.

The following information will help us better understand what's going on:

If you are using velero v1.7.0+:
Please use velero debug --backup <backupname> --restore <restorename> to generate the support bundle, and attach to this issue, more options please refer to velero debug --help

If you are using earlier versions:
Please provide the output of the following commands (Pasting long output into a GitHub gist or other pastebin is fine.)

  • kubectl logs deployment/velero -n velero
  • velero backup describe <backupname> or kubectl get backup/<backupname> -n velero -o yaml
  • velero backup logs <backupname>
  • velero restore describe <restorename> or kubectl get restore/<restorename> -n velero -o yaml
  • velero restore logs <restorename>

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Velero version (use velero version): 1.8.1
  • Velero features (use velero client config get features): nil
  • Kubernetes version (use kubectl version):nil
  • Kubernetes installer & version:nil
  • Cloud provider or hardware configuration:nil
  • OS (e.g. from /etc/os-release):macOS 12.3.1 (Apple M1 silicon)

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@blackpiglet blackpiglet added Needs investigation Area/CLI related to the command-line interface labels May 16, 2022
@blackpiglet
Copy link
Contributor

blackpiglet commented May 16, 2022

@drummerglen
I found this issue on cobra: spf13/cobra#1529

Cobra doesn't support source completion way by default.
Helm and kubectl can do that, because they do some modification of cobra's output.

Velero's commended way to do completion is output to a file.

Zsh:

# If shell completion is not already enabled in your environment you will need
# to enable it.  You can execute the following once:

$ echo "autoload -U compinit; compinit" >> ~/.zshrc

# To load completions for each session, execute once:
$ velero completion zsh > "${fpath[1]}/_velero"

@blackpiglet blackpiglet self-assigned this May 16, 2022
@blackpiglet
Copy link
Contributor

After taking another thought on this, I think cobra being carefully on this is reasonable, but Velero can do that with some simple change.
I will create a PR for this.

@drummerglen
Copy link
Author

@blackpiglet Cool, Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/CLI related to the command-line interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants