Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Restore controller with kubebuilder #5027

Closed
blackpiglet opened this issue Jun 19, 2022 · 3 comments · Fixed by #5759 or #5864
Closed

Refactor Restore controller with kubebuilder #5027

blackpiglet opened this issue Jun 19, 2022 · 3 comments · Fixed by #5759 or #5864
Assignees
Milestone

Comments

@blackpiglet
Copy link
Contributor

Describe the problem/challenge you have
[A description of the current limitation/problem/challenge that you are experiencing.]
A sub task of epic #2597 to refactor Restore controller with kubebuilder.

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@reasonerjt
Copy link
Contributor

Per discussion we may have limited bandwidth to handle the refactor for restore controller, moving it out of v1.10

@blackpiglet
Copy link
Contributor Author

After checking the backup and restore controller code, I think we can separate the VSL client, backup lister, getter, and other related client-go client into a sub-task, but there is not much other things can be splitted, and I think maybe there could be not that much effort as we expected for these two controllers, because many functions are not related to the kubebuilder, and the process shoule be similar to other controllers refactor PR.

@blackpiglet
Copy link
Contributor Author

blackpiglet commented Feb 3, 2023

Phase 1 of removing the unneeded client is done, but there is still phase 2 to adopt the controller-runtime framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment