-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry upload codecov when rate limit is hit. #7787
Comments
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands. |
Should be solved with codecov/codecov-action@7594baa Already using v4 so should be fine. |
The update doesn't fix anything for me. Does anyone know an alternative solution for codecov? Doesn't even have to be such a full blown solution. |
we could use Go provided tools Example command in Makefile COVERAGE_THRESHOLD=80
.PHONY: check-coverage
check-coverage: ## Check if test coverage threshold was reached.
@{ \
set -e ;\
current_coverage=$(shell go tool cover -func=cover.out | grep total | grep -Eo "[0-9]+\.[0-9]+") ;\
if [ "$$(echo "$$current_coverage < $(COVERAGE_THRESHOLD)" | bc -l)" -eq 1 ];then \
echo "Current coverage ($$current_coverage%) is below project threshold of $(COVERAGE_THRESHOLD)%" ;\
exit 1 ;\
fi ;\
echo "Coverage threshold of $(COVERAGE_THRESHOLD)% reached: $$current_coverage%" ;\
} |
What steps did you take and what happened:
Following happened.
What did you expect to happen:
This rate limit to not fail Run CI job.
Expected available in 197 seconds.
from log can be used to wait before retrying again.Anything else you would like to add:
Could potentially be solved via Codecov CLI repo codecov/codecov-cli#441
codecov/feedback#358
Environment:
velero version
):velero client config get features
):kubectl version
):/etc/os-release
):Vote on this issue!
This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.
The text was updated successfully, but these errors were encountered: