Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry backup failing deletion from object locks after user intervention. #8691

Open
kaovilai opened this issue Feb 14, 2025 · 0 comments
Open
Labels
Enhancement/User End-User Enhancement to Velero

Comments

@kaovilai
Copy link
Member

Describe the problem/challenge you have

If a backup expires, and velero fail to clean up due to object locks, velero should update local Backup CR to reflect this either in status or annotation.

Perhaps add a finalizer to backup as otherwise user manually deleting this backup CR will mean no velero instance will ever clean this backup again as it won't sync to cluster due to expiration.

User acknowledges that if finalizer is removed, velero will only retry to cleanup one more time (if there is a detectable event), and CR will be gone forever and not sync back. Data may remain in bucket if user still had object lock on during finalizer removal.

User can add annotate backup or BSL once they have resolved the issue, velero will retry cleanup and remove finalizer to complete the deletion.

Describe the solution you'd like

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@kaovilai kaovilai added the Enhancement/User End-User Enhancement to Velero label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement/User End-User Enhancement to Velero
Projects
None yet
Development

No branches or pull requests

1 participant