Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kind cli to v0.27.0 #8699

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Feb 18, 2025

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #8698

Please indicate you've done the following:

@kaovilai
Copy link
Member Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Feb 18, 2025
@kaovilai kaovilai closed this Feb 18, 2025
@kaovilai kaovilai reopened this Feb 18, 2025
@github-actions github-actions bot requested a review from reasonerjt February 18, 2025 02:00
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.48%. Comparing base (a3cee61) to head (af1d2eb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8699      +/-   ##
==========================================
+ Coverage   59.46%   59.48%   +0.01%     
==========================================
  Files         371      371              
  Lines       40196    40196              
==========================================
+ Hits        23903    23911       +8     
+ Misses      14798    14791       -7     
+ Partials     1495     1494       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet
Copy link
Contributor

Finally, the KinD released a working tag.
Thanks for the fix.

blackpiglet
blackpiglet previously approved these changes Feb 18, 2025
with:
version: "v0.21.0"
version: "v0.27.0"
Copy link
Contributor

@blackpiglet blackpiglet Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to add skipClusterLogsExport: true in the engineerd/setup-kind action's with parameter to avoid error in the post step.

The new post step introduced in the engineerd/setup-kind@v0.6.2 exports the action logs to a specified directory. That causes an error due to running multiple actions, and all of them share the same log directory, which is a UUID.
As a result, only the first finished action can pass the post step. All the others fail due to the log directory already exists.

https://github.com/engineerd/setup-kind

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was toying with adding unique kind name... skip sounds easier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passing except lint (in CI).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can have another way to fix the post-step issue, it would be great. If not, it's OK in my opinion.
There is another PR to address the linter issue.

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai
Copy link
Member Author

kibishi failing on waiting to be ready in some cases..

fmt.Printf("Pod %s is in state %s waiting for it to be %s\n", podName, checkPod.Status.Phase, corev1.PodRunning)

@blackpiglet
Copy link
Contributor

It's OK to me. This is more like an environment issue.

@kaovilai
Copy link
Member Author

basically all "images pre-built for this release" for 0.27.0

@kaovilai
Copy link
Member Author

if not succcessful maybe skip all containerdv2 images for now.

@kaovilai
Copy link
Member Author

kaovilai commented Feb 18, 2025

in the meantime another workaround posted in #8700

@kaovilai kaovilai marked this pull request as draft February 18, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump kind CLI to v0.27.0
2 participants