-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump kind cli to v0.27.0 #8699
base: main
Are you sure you want to change the base?
Bump kind cli to v0.27.0 #8699
Conversation
/kind changelog-not-required |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8699 +/- ##
==========================================
+ Coverage 59.46% 59.48% +0.01%
==========================================
Files 371 371
Lines 40196 40196
==========================================
+ Hits 23903 23911 +8
+ Misses 14798 14791 -7
+ Partials 1495 1494 -1 ☔ View full report in Codecov by Sentry. |
4ccd674
to
5a07c11
Compare
Finally, the KinD released a working tag. |
with: | ||
version: "v0.21.0" | ||
version: "v0.27.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to add skipClusterLogsExport: true
in the engineerd/setup-kind
action's with
parameter to avoid error in the post step.
The new post step introduced in the engineerd/setup-kind@v0.6.2
exports the action logs to a specified directory. That causes an error due to running multiple actions, and all of them share the same log directory, which is a UUID.
As a result, only the first finished action can pass the post step. All the others fail due to the log directory already exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was toying with adding unique kind name... skip sounds easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passing except lint (in CI).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can have another way to fix the post-step issue, it would be great. If not, it's OK in my opinion.
There is another PR to address the linter issue.
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
5a07c11
to
af1d2eb
Compare
kibishi failing on waiting to be ready in some cases.. velero/test/util/k8s/common.go Line 72 in a628cb5
|
It's OK to me. This is more like an environment issue. |
basically all "images pre-built for this release" for 0.27.0 |
if not succcessful maybe skip all containerdv2 images for now. |
in the meantime another workaround posted in #8700 |
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #8698
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.