-
Notifications
You must be signed in to change notification settings - Fork 95
moving updated MD files from gh-pages branch to vmware/master/doc [SKIP CI] #1535
moving updated MD files from gh-pages branch to vmware/master/doc [SKIP CI] #1535
Conversation
@@ -1,8 +1,9 @@ | |||
* IMPORTANT: This is an experimental feature supported only on standalone ESX as of release 0.12. We are seeking feedback/requirements to support mult-tenancy across vSphere Cluster/Datacenter. You can drop us a note at containers@vmware.com. | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multi-tenancy is not a experimental feature any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry .. can you elaborate here? what do you mean by "Multi-tenancy is not a experimental feature any more?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that you delete the paragraph that "multi-tenancy is a experimental feature".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's take care as part of #1536.
``` | ||
|
||
### Default privileges | ||
When a VM tries to manipulate volumes on a datastore which is not configured, the system will use _DEFAULT privilege, which is created automatically by system post install. This _DEFAULT privilege allows access to ANY datastore by default. An admin can edit or remove this record, thus locking down the functionality to allow access only to explicitly configured datastores. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have default privileges, instead, we create privileges to "_ALL_DS" and "_VM_DS" for default vmgroup post install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case vmware/master/docs/features/tenancy.md
is having redundant information and needs to be removed and we can manage such information at admin_cli.md
only.
/CC @msterin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be taken care by #1536
When a VM addresses the volume using short notation (volume_name, without @datastore), all VMs in this vmgroup will use default datastore to resolve short volume reference (volume_name will actually mean volume_name@default_datastore). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, "default_datastore" is must be set when creating a vmgroup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be taken care by #1536
If "default_datastore" is not set for a vmgroup, then datastore where the VM resides will be used as "default_datastore". | ||
|
||
## Example | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following example need to be updated. "default_datastore" must be specified when creating a vmgroup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
admin-cli.md has the updated info regarding the behavior for multi-tenancy, so tenency.md need to be updated accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be taken care by #1536
docs/user-guide/docker-volume-cli.md
Outdated
1. Thick Provision Lazy Zeroed ([zeroedthick]((https://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=1022242))) | ||
2. Thin Provision ([thin]((https://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=1022242))) | ||
3. Thick Provision Eager Zeroed ([eagerzeroedthick]((https://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=1022242))) | ||
1. Persistent mode: In persistent mode the VMDK becomes part of VM the snapshot if a snapshot of the VM is taken while VMDK was attached. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: "VM the snapshot" -> "the VM snapshot"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
Lets consider a sample use case where there are 2 teams – Dev and Test working on Product1. Lets create separate vmgroups (namely Product1Dev and Product2Test) for each of the teams where we can put restriction on datastore consumption. | ||
|
||
``` | ||
# /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py vmgroup create --name=Product1Dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should correct this example here - we are not specifying --default-datatsore here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be taken care by #1536
# /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py vmgroup create --name=Product1Dev | ||
vmgroup 'Product1Dev' is created. Do not forget to run 'vmgroup vm add' and 'vmgroup access add' commands to enable access control. | ||
|
||
#/usr/lib/vmware/vmdkops/bin/vmdkops_admin.py vmgroup create --name=Product1Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Default_datastore" is a required parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be taken care by #1536
docs/features/vcenter.md
Outdated
@@ -1,3 +1,5 @@ | |||
###... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this if does this does not adds any value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
moving updated MD files from gh-pages branch to vmware/master/doc.
This is a final PR to meet objective of #1370
As part of #1498, missing commits from
vmware/master/docs/*.md
merged togh-pages/jeckyll-docs/*.md
; so the content has been in synced. Now gh-pages were having some formatting changes were left out invmware/master/docs/*.md
hence this PR.Note: This is PR is to bring changes made in gh-pages which never made to
vmware/master/docs/*.md
.After this PR content and format for both
vmware/master/docs
&gh-pages/
will be in sync, at the release all changes fromvmware/master/docs
copies togh-pages/
.