This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
[SKIP CI] Update tenancy.md #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuklanirdesh82
suggested changes
Jul 5, 2017
docs/features/tenancy.md
Outdated
| @@ -83,39 +97,40 @@ f15c1f6d-5df5-4a00-8f20-77c8e7a7af11 Product1Test | |||
| Lets limit dev team to create volumes of total 20 Gb each not exceeding size of 1 GB. Similarly for QA team, lets put restriction of total 40 GB consumption with each volume size not exceeding 1 GB. | |||
|
|
|||
| ``` | |||
| #/usr/lib/vmware/vmdkops/bin/vmdkops_admin.py vmgroup access add --name=Product1Dev --datastore=datastore3 --allow-create --default-datastore --volume-maxsize=1GB --volume-totalsize=20GB | |||
| vmgroup access add succeeded | |||
| [root@sc-rdops-vm17-dhcp-3-236:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py vmgroup access set --name=Product1Dev --datastore=sharedVmfs-0 --volume-maxsize=1GB --volume-totalsize=20GB | |||
There was a problem hiding this comment.
--datastore=sharedVmfs-0 why? so far the document was referring to datastore3 .
docs/features/tenancy.md
Outdated
| [root@sc-rdops-vm17-dhcp-3-236:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py vmgroup access set --name=Product1Dev --datastore=sharedVmfs-0 --volume-maxsize=1GB --volume-totalsize=20GB | ||
| vmgroup access set succeeded | ||
|
|
||
| [root@sc-rdops-vm17-dhcp-3-236:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py vmgroup access set --name=Product1Test --datastore=sharedVmfs-0 --volume-maxsize=1GB --volume-totalsize=40GB |
docs/features/tenancy.md
Outdated
|
|
||
| #/usr/lib/vmware/vmdkops/bin/vmdkops_admin.py vmgroup access add --name=Product1Test --datastore=datastore3 --allow-create --default-datastore --volume-maxsize=1GB --volume-totalsize=40GB | ||
| vmgroup access add succeeded | ||
| ``` | ||
| Lets verify that storage restrictions has been set properly. |
There was a problem hiding this comment.
not for this review, as you are here to update .. can you address following nit?
restrictions has been set properly => restrictions have been set properly
|
@lipingxue Can you please fix following broke link too from tenancy.md?
|
lipingxue
force-pushed
the
tenancy_md.liping
branch
from
49abdf6
to
3f01235
Compare
|
@shuklanirdesh82 I have addressed your comments, please take a look. |
shaominchen
approved these changes
Jul 5, 2017
docs/features/tenancy.md
Outdated
| ### Default datastore | ||
| When a VM addresses the volume using short notation (volume_name, without @datastore), all VMs in this vmgroup will use default datastore to resolve short volume reference (volume_name will actually mean volume_name@default_datastore). | ||
|
|
||
| If "default_datastore" is not set for a vmgroup, then datastore where the VM resides will be used as "default_datastore". | ||
| "Default_datastore" is a required parameter when creating a vmgroup. The value is either a valid datastore name, or special string "_VM_DS. The "Default_datastore" field is set to "_VM_DS" for "_DEFAULT" vmgroup post install and any volume create from VM which belongs to "_DEFAULT" vmgroup will be created on the datastore where VM resides. |
There was a problem hiding this comment.
Nits:
- "_VM_DS - we are missing the matching quotation mark here.
- volume create from VM => volume created from VM
docs/features/tenancy.md
Outdated
|
|
||
| ## Example | ||
|
|
||
| Lets consider a sample use case where there are 2 teams – Dev and Test working on Product1. Lets create separate vmgroups (namely Product1Dev and Product2Test) for each of the teams where we can put restriction on datastore consumption. | ||
| Lets consider a sample use case where there are 2 teams – Dev and Test working on Product1. Lets create separate vmgroups (namely Product1Dev and Product1Test) for each of the teams where we can put restriction on datastore consumption. |
shuklanirdesh82
approved these changes
Jul 6, 2017
Address comments from Nirdesh. Minor fix. Minor fix again.
lipingxue
force-pushed
the
tenancy_md.liping
branch
from
3f01235
to
e42358e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1536
This PR updates tenancy.md to match the up-to-date multi-tenancy behavior.