This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Returning proper exit code in cases where vmdkops admin command fails. #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Maintaining unambiguity through returning proper exit code when command fails along with message print. 2. Removed redundant helper to print the error message and return it. Fixes vmware-archive#1522
shaominchen
reviewed
Jul 6, 2017
| @@ -958,7 +954,7 @@ def tenant_create(args): | |||
| privileges=[]) | |||
|
|
|||
| if error_info: | |||
| return operation_fail(error_info.msg) | |||
There was a problem hiding this comment.
Is operation_fail still being used? If not, we should remove it.
There was a problem hiding this comment.
Yes I have removed it. See line 902
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about returning proper exit code to indicate error when command fails to maintain consistency.
Removed redundant helper to print the error message and return it.
Fixes #1522
Testing:
test-e2e passes
Manual testing (Sample):