This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Update in CONTRIBUTING.md [SKIP CI] #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
CONTRIBUTING.md
Outdated
| @@ -119,7 +119,7 @@ correct environment. | |||
| - You **need** to set ESX and VM1, VM2 and VM3 environment variables | |||
|
|
|||
| - The build will use your `username` (the output of `whoami`) to decide on the `DOCKER_HUB_REPO` name to complete our move to use [managed plugin](https://github.com/vmware/docker-volume-vsphere/blob/master/plugin/Makefile#L30). | |||
| If you want to user another DockerHub repository you need to set `DOCKER_HUB_REPO` as environment variable. | |||
| If you want to user another DockerHub repository you need to set `DOCKER_HUB_REPO` as environment variable. The prerequisite to user another DockerHub repository is to have a DockerHub account and be able to access the repository owned by this account. If you don't have a DockerHub account, you need to create an account [here](https://hub.docker.com/). | |||
There was a problem hiding this comment.
I would suggest to move this new instruction before L121 ...
lipingxue
force-pushed
the
document.liping
branch
from
93b9b40 to
df42fe0
Compare
Address comments from Nirdesh. Minor fix.
lipingxue
force-pushed
the
document.liping
branch
from
cfcee09 to
9caf78e
Compare
|
@shuklanirdesh82 I have addressed your comment and please take a look. |
shuklanirdesh82
approved these changes
Jul 18, 2017
CONTRIBUTING.md
Outdated
| @@ -115,6 +115,10 @@ To deploy the plugin and test code onto a test environment we support a set of | |||
| Makefile targets. There targets rely on environment variables to point to the | |||
There was a problem hiding this comment.
As you are here to update .. small request to correct the typo: There => These
ashahi1
approved these changes
Jul 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1429
This PR updated the contributing.md to include the prerequisite when building with another dockerhub account other than the 'username'.