This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
allow user to choose ETCD ports for vFile usage #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipingxue
force-pushed
the
etcd_port.liping
branch
from
0df4ce9
to
de12d46
Compare
luomiao
reviewed
Nov 20, 2017
| @@ -893,6 +916,7 @@ func (e *EtcdKVS) createEtcdClient() *etcdClient.Client { | |||
| func addrToEtcdClient(addr string) (*etcdClient.Client, error) { | |||
| // input address are RemoteManagers from docker info or ManagerStatus.Addr from docker inspect | |||
| // in the format of [host]:[docker manager port] | |||
| etcdClientPort, _ := getEtcdPorts() | |||
There was a problem hiding this comment.
This addrToEtcdClient function is called inside createEtcdClient function and will be called for almost every ETCD operations. So calling getEtcdPorts inside this function is not efficient (means everytime we have to read ENVs although they are never changed across the same installation since they are installation flags).
I suggest that we should call getEtcdPorts at the very beginning and then store the information inside the local EtcdKVS struct. And later in addrToEtcdClient we just need to grab this information locally, instead of reading the ENV flags again and again.
There was a problem hiding this comment.
@luomiao I have addressed your comments, please take a look. Thanks!
luomiao
approved these changes
Nov 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1970
With this change, user can specify etcd cluster port number other than default value (default etcdClientPort is 2379 and etcdClientPort is 2380) used by vFile.
User need to specify those port numbers through environment variable "VFILE_ETCD_CLIENT_PORT" and "VFILE_ETCD_PEER_PORT", see the following example:
After install the vFile plugin, test basic volume create/mount/unmount, works as expected.