Skip to content

Commit 890fda1

Browse files
committed
Self review
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
1 parent 0bd40f0 commit 890fda1

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.changes/v2.23.0/652-improvements.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
* New public method `VApp.GetParentVDC` to retrieve parent VDC of vApp (previously it was private)
2-
[GH-642]
2+
[GH-652]
33
* New methods `Catalog.CaptureVappTemplate`, `Catalog.CaptureVappTemplateAsync` and type
44
`types.CaptureVAppParams` that add support for creating catalog template from existing vApp
5-
[GH-642]
6-
* New method `Org.GetVAppByHref` to retrieve a vApp by given HREF [GH-642]
5+
[GH-652]
6+
* New method `Org.GetVAppByHref` to retrieve a vApp by given HREF [GH-652]
77
* New methods `VAppTemplate.GetCatalogItemHref` and `VAppTemplate.GetCatalogItemId` that can return
8-
related catalog item ID and HREF [GH-642]
8+
related catalog item ID and HREF [GH-652]

govcd/vapptemplate.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ func (vAppTemplate *VAppTemplate) GetCatalogItemHref() (string, error) {
375375
return "", fmt.Errorf("error finding Catalog Item link in vApp template %s", vAppTemplate.VAppTemplate.ID)
376376
}
377377

378-
// GetCatalogItemHref looks up Href for catalog item in vApp template
378+
// GetCatalogItemId returns ID for catalog item in vApp template
379379
func (vAppTemplate *VAppTemplate) GetCatalogItemId() (string, error) {
380380
href, err := vAppTemplate.GetCatalogItemHref()
381381
if err != nil {

types/v56/types.go

+1
Original file line numberDiff line numberDiff line change
@@ -1627,6 +1627,7 @@ type CaptureVAppParams struct {
16271627
// template with the one created by this capture, place a reference to the existing template
16281628
// here. Otherwise, the operation creates a new vApp template.
16291629
TargetCatalogItem *Reference `xml:"TargetCatalogItem,omitempty"`
1630+
16301631
// CopyTpmOnInstantiate defines if TPM device is copied (`true`) to instantiated vApp from this
16311632
// template or `false` if a new TPM device is created for instantiated vApp.
16321633
// Note. Supported on VCD 10.4.2+

0 commit comments

Comments
 (0)