Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssoadmin:create local group and add users to group #1327

Merged
merged 3 commits into from
Dec 7, 2018
Merged

ssoadmin:create local group and add users to group #1327

merged 3 commits into from
Dec 7, 2018

Conversation

AndrewDi
Copy link
Contributor

@AndrewDi AndrewDi commented Dec 6, 2018

Make ssoadmin to support CREATE GROUP and Add Users To Group.

@vmwclabot
Copy link
Member

@AndrewDi, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

dougm
dougm reviewed Dec 6, 2018
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndrewDi , looks good. Can we collapase the 2 methods into a single AddUsersToGroup method?

ssoadmin/client.go Outdated Show resolved Hide resolved
@vmwclabot
Copy link
Member

@AndrewDi, VMware has approved your signed contributor license agreement.

dougm
dougm approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndrewDi !

@dougm dougm merged commit 86f4ba2 into vmware:master Dec 7, 2018
@AndrewDi AndrewDi deleted the add_localgroup branch December 10, 2018 04:32
@dougm dougm added this to the 2018.12 milestone Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2018.12
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewDi @vmwclabot @dougm