vcsim: Sets "ChangeTrackingSupported" property of the simulated VM #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanpaha
force-pushed
the
amanpaha/vcsim-changetrackingsupported
branch
from
36b652b to
7b961a8
Compare
dougm
reviewed
May 27, 2021
simulator/virtual_machine.go
Outdated
| for _, device := range spec.DeviceChange { | ||
| if dev, ok := device.GetVirtualDeviceConfigSpec().Device.(*types.VirtualDisk); ok { | ||
|
|
||
| if _, ok := dev.Backing.(*types.VirtualDiskFlatVer2BackingInfo); ok { |
There was a problem hiding this comment.
Thanks @amanpaha , your first commit used a switch dev.Backing.(type), which is what I would suggest here. I think changeTrackingSupported can return bool instead of *bool, then each case can return true and the default case return false. Then use the NewBool helper to convert to a pointer:
vm.Capability.ChangeTrackingSupported = types.NewBool(changeTrackingSupported(spec))What do you think?
There was a problem hiding this comment.
Yes, definitely looks good now, thanks for the suggestion.
I have made the change, should I resolve the conversation or reviewer will do it after verifying that the correct changes were made.
changing swtich to if block Reverting to switch block
amanpaha
force-pushed
the
amanpaha/vcsim-changetrackingsupported
branch
from
b3d7bd7 to
44ae85f
Compare
|
@amanpaha, VMware has approved your signed contributor license agreement. |
dougm
approved these changes
May 28, 2021
protochron
pushed a commit
to protochron/govmomi
that referenced
this pull request
Aug 31, 2021
yuyin002
pushed a commit
to yuyin002/govmomi
that referenced
this pull request
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change checks the device type and sets ChangeTrackingSupported property for the simulated VM accordingly.
Before enabling change tracking for VM, we validates if change tracking is supported or not by checking the Capability.ChangeTrackingSupported property. While writing unit test we are using vcsim for getting simulated VM but we cant test our functionality after checking ChangeTrackingSupported, since it is always nil.
How Has This Been Tested?
Ran virtual_machine_test.go (package simulator) to see if this property is populated or not.