toolbox: validate request offset in ListFiles #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ListFiles handler assumed the 'offset' param was always valid. It could be invalid if client-side logic is wrong or directory contents have shrunk in between calls. Either way, we reply with '0' remaining files in this case as open-vm-tools does. Fixes vmware#934
|
@gigawhitlocks can you review? |
gigawhitlocks
approved these changes
Dec 11, 2017
|
Sorry that took me so long; didn't see the notification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ListFiles handler assumed the 'offset' param was always valid.
It could be invalid if client-side logic is wrong or directory contents have shrunk in between calls.
Either way, we reply with '0' remaining files in this case as open-vm-tools does.
Fixes #934