Additional edge gateway external network features: multiple external networks, manual IP assignment, IP pool sub-allocation #323
Comments
|
Partly related to https://github.com/terraform-providers/terraform-provider-vcd/issues/308 (could be done together) |
|
Hi @okozarva, thanks for the issue. I need to clarify a bit with you so that this is clearer when someone starts to work. You want to be able to manually specify 1 or more IP addresses in different subnets (and external networks) to be attached to edge gateway?
As well as use sub-allocated ranges in the external network subnets?
|
|
Hi @Didainius, Thanks for your quick response. That's features will be perfect.
|
Didainius
changed the title
|
With automatic IP assignment I had an issue creating in parallel two edges on the same external network: the second creation failed because terraform try to use the same address of the first one. and edges are created with IP1 and IP2=IP1+1 |
|
Cross-referencing #308 because it would be very cheap to implement it while working on this PR. |
@carmineesposito73 , |
Doh. I am building a new structure to support manual IP addresses and misread your note. You are using the "dynamic" IPs, but I still can't replicate the issue. Tried creating 4 edge gateways in parallel with automatic IP assignment as well. |
|
@Didainius I used vcloud 8.20. |
Thanks - I will try that. A heads-up though - we're dropping support for 8.20 in the upcoming 2.6.0 as we have to start using newer version of API. |
|
Just to clarify, support was dropped in 2.5.0, but it still worked as the used API version didn't change. While with 2.6.0 vCD 8.20 won't work. |
|
@carmineesposito73, @okozarva, I have a draft PR (https://github.com/terraform-providers/terraform-provider-vcd/pull/401) which should satisfy your needs, but feedback is very welcome as this was a tricky one due to troublesome API structure. I'm going to further test it, but initial tests were positive (structure is still subject to change). You can check documentation from my PR branch (https://github.com/terraform-providers/terraform-provider-vcd/blob/31716df8198f01d29ec3a070c99368b43d4731a1/website/docs/r/edgegateway.html.markdown) |
|
@Didainius I confirm the issue when edge_1 is not advanced and edge_2 is advanced. |
|
@carmineesposito73, thanks! I will try to replicate it this way then |
…le subnet support (#267) * Adds settings/proves the capability of edge gateway being able to attach multiple subnets and sub-allocation pools (terraform-providers/terraform-provider-vcd#323 ) * Adds additional missing settings to edge gateway structure * Converts some bool fields to pointers to better distinguish between empty value and false.
|
@okozarva , @carmineesposito73 - this PR is merged to master. I'd appreciate if you can give it a spin and report if there are any issues as we are aiming for a a release soon. |
|
hi @Didainius, I got this error: the configuration is the following I tried with advanced and not advanced gw. I'll try to do some changes to make things working |
|
That is great! Thank you for testing. I did see it some time ago, but I thought I have fixed as I did cover my cases. |
|
FipsModeEnabled is present since API 30.0 |
|
I'll check that on vcd 9.0 - this may be the secret about it. I might have not tested it with 9.0 as we haven't reached pre-release testing phase. Although I am using the same API version 29 - it did work on 9.5. Will do some more testing later today and report. |
|
it works with this "quick and dirty" patch I'm sorry I use the oldest vCloud version supported :-S |
|
It is good. We still support it so you saved me some time on catching the bug early before we have a pre-release testing. I will look at how to make this work. |
The issue is no more present, I created edge_1 not advanced and edge_2 advanced in parallel with auto-assigned ip, they got IP and IP+1 |
|
@Didainius, changing suballocated ip addresses (adding a range or extend the range) requires the edge to be destroyed. Is it as expected? |
|
@carmineesposito73, so far yes. We have yet another issue to fix all edge gateway related updates ( partly mentioned in https://github.com/terraform-providers/terraform-provider-vcd/issues/369). I had to split the PR as it was hard to review because of the structure it implies. |
|
I think that can be useful to have automatic suballocation as an option (as it is for edge ip assignment), something like that:
|
|
Could you elaborate a bit more what your full workflow would be? |
|
This is the use case I'm thinking about: I don't know if I've answered you question |
Yes, thanks! Let me think about it and come back. |
|
@carmineesposito73 , regarding FIPS mode. Could you try to build it from this branch - https://github.com/Didainius/terraform-provider-vcd/tree/fips-mode-fix ? It does not send the field data when |
|
great! |
|
if |
|
Thanks! That was my original intention - I did send the request after this warning although I may decide to just bail out when it is run with vCD 9.0 and let the user remove this setting. |
I guess that my request regarding suballocated ip is out-of-the-scope :-( |
I had my thoughts about it and yes - we are not adding any "extra logic" on top of what exists in vCD so implement your above example would require some computations on provider side and that usually bites us back sooner or later. |
|
@Didainius, I have to agree with you. |
|
It works thank you @Didainius |
|
@Didainius, just a question, does I see only one external network block, but the edge has 2 external networks here is the extract of api get |
@carmineesposito73, there is a problem in Terraform sdk (from Hashicorp) with multiple typeset computed blocks and sdk fix didn’t get merged for our 2.6 release timeframe (still pending PR hashicorp/terraform-plugin-sdk#197). As soon as terraform sdk is fixed we are going to bump sdk dependency version in our provider and it should start showing multiple external network blocks in future versions. |
Terraform Version
Terraform v0.12.5
Affected Resource(s)
Please list the resources as a list, for example:
Expected Behavior
The text was updated successfully, but these errors were encountered: